All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, alex.williamson@redhat.com,
	mtosatti@redhat.com, gleb@kernel.org, jan.kiszka@siemens.com
Subject: [PATCH 1/4] KVM: vmx: we do rely on loading DR7 on entry
Date: Wed, 26 Feb 2014 16:49:10 +0100	[thread overview]
Message-ID: <1393429753-20857-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1393429753-20857-1-git-send-email-pbonzini@redhat.com>

Currently, this works even if the bit is not in "min", because the bit is always
set in MSR_IA32_VMX_ENTRY_CTLS.  Mention it for the sake of documentation, and
to avoid surprises if we later switch to MSR_IA32_VMX_TRUE_ENTRY_CTLS.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 arch/x86/kvm/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index daca80f0eae2..6e57e1434cf3 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2872,7 +2872,7 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf)
 		!(_vmexit_control & VM_EXIT_ACK_INTR_ON_EXIT))
 		_pin_based_exec_control &= ~PIN_BASED_POSTED_INTR;
 
-	min = 0;
+	min = VM_ENTRY_LOAD_DEBUG_CONTROLS;
 	opt = VM_ENTRY_LOAD_IA32_PAT | VM_ENTRY_LOAD_BNDCFGS;
 	if (adjust_vmx_controls(min, opt, MSR_IA32_VMX_ENTRY_CTLS,
 				&_vmentry_control) < 0)
-- 
1.8.3.1



  reply	other threads:[~2014-02-26 15:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 15:49 [PATCH 0/4] KVM: x86: Let the guest write to multiple debug registers with one vmexit Paolo Bonzini
2014-02-26 15:49 ` Paolo Bonzini [this message]
2014-02-26 15:49 ` [PATCH 2/4] KVM: x86: change vcpu->arch.switch_db_regs to a bit mask Paolo Bonzini
2014-02-26 15:49 ` [PATCH 3/4] KVM: x86: Allow the guest to run with dirty debug registers Paolo Bonzini
2014-02-26 15:49 ` [PATCH 4/4] KVM: vmx: " Paolo Bonzini
2014-02-27 11:25   ` Jan Kiszka
2014-02-27 12:54     ` Paolo Bonzini
2014-02-26 17:00 ` [PATCH 0/4] KVM: x86: Let the guest write to multiple debug registers with one vmexit Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393429753-20857-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=gleb@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.