All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Vadai <amirv@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Yevgeny Petrilin <yevgenyp@mellanox.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Eyal Perry <eyalpe@mellanox.com>, Amir Vadai <amirv@mellanox.com>
Subject: [PATCH net-next 7/9] net/mlx4_core: Fix sparse warning
Date: Thu, 27 Feb 2014 14:27:04 +0200	[thread overview]
Message-ID: <1393504026-13384-8-git-send-email-amirv@mellanox.com> (raw)
In-Reply-To: <1393504026-13384-1-git-send-email-amirv@mellanox.com>

From: Eyal Perry <eyalpe@mellanox.com>

This patch force conversion to u32 to fix the following sparse warning:
drivers/net/ethernet/mellanox/mlx4/fw.c:1822:53: warning: restricted __be32
degrades to integer

Casting to u32 is safe here, because token will be returned as is
from the hardware without any modification.

Signed-off-by: Eyal Perry <eyalpe@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx4/fw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
index 91b69ff..9cdf452 100644
--- a/drivers/net/ethernet/mellanox/mlx4/fw.c
+++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
@@ -1890,7 +1890,8 @@ void mlx4_opreq_action(struct work_struct *work)
 			err = EINVAL;
 			break;
 		}
-		err = mlx4_cmd(dev, 0, ((u32) err | cpu_to_be32(token) << 16),
+		err = mlx4_cmd(dev, 0, ((u32) err |
+					(__force u32)cpu_to_be32(token) << 16),
 			       1, MLX4_CMD_GET_OP_REQ, MLX4_CMD_TIME_CLASS_A,
 			       MLX4_CMD_NATIVE);
 		if (err) {
-- 
1.8.3.4

  parent reply	other threads:[~2014-02-27 12:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 12:26 [PATCH net-next 0/9] net/mlx4: Mellanox driver update 27-02-2014 Amir Vadai
2014-02-27 12:26 ` [PATCH net-next 1/9] net/mlx4_en: Fix UP limit in ieee_ets->prio_tc Amir Vadai
2014-02-27 12:26 ` [PATCH net-next 2/9] net/mlx4_en: Verify mlx4_en module parameters Amir Vadai
2014-02-27 12:27 ` [PATCH net-next 3/9] net/mlx4_en: Pad ethernet packets smaller than 17 bytes Amir Vadai
2014-02-27 13:08   ` David Laight
2014-02-27 14:02     ` Amir Vadai
2014-02-27 14:44       ` Eric Dumazet
2014-02-27 15:46         ` Amir Vadai
2014-02-27 20:36           ` David Miller
2014-02-27 21:47             ` Amir Vadai
2014-02-27 21:58               ` David Miller
2014-02-27 12:27 ` [PATCH net-next 4/9] net/mlx4_en: Move queue stopped/waked counters to be per ring Amir Vadai
2014-02-27 12:27 ` [PATCH net-next 5/9] net/mlx4: Replace mlx4_en_mac_to_u64() with mlx4_mac_to_u64() Amir Vadai
2014-02-27 12:27 ` [PATCH net-next 6/9] net/mlx4_en: Fix selftest failing on non 10G link speed Amir Vadai
2014-02-27 12:27 ` Amir Vadai [this message]
2014-02-27 12:27 ` [PATCH net-next 8/9] net/mlx4_en: Use union for BlueFlame WQE Amir Vadai
2014-02-27 12:27 ` [PATCH net-next 9/9] net/mlx4_en: Change Connect-X description in kconfig Amir Vadai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393504026-13384-8-git-send-email-amirv@mellanox.com \
    --to=amirv@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=eyalpe@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=yevgenyp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.