From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] socfpga: Adding DesignWare watchdog support
Date: Thu, 27 Feb 2014 13:55:53 -0600 [thread overview]
Message-ID: <1393530953.1993.3.camel@clsee-VirtualBox.altera.com> (raw)
In-Reply-To: <530AFA54.2070401@monstr.eu>
Hi Michal,
On Mon, 2014-02-24 at 08:52 +0100, Michal Simek wrote:
> On 02/21/2014 09:57 PM, Chin Liang See wrote:
> > To enable the DesignWare watchdog support at SOCFPGA Cyclone V
> > dev kit.
> >
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Anatolij Gustschin <agust@denx.de>
> > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Tom Rini <trini@ti.com>
> > ---
> > Changes for v3
> > - Split to 2 series patch
> > Changes for v2
> > - Enable this driver at socfpga_cyclone5 board
> > ---
> > .../include/asm/arch-socfpga/socfpga_base_addrs.h | 1 +
> > include/configs/socfpga_cyclone5.h | 13 +++++++++++++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
> > index 20f12e0..5f73824 100644
> > --- a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
> > +++ b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
> > @@ -11,6 +11,7 @@
> > #define SOCFPGA_UART0_ADDRESS 0xffc02000
> > #define SOCFPGA_UART1_ADDRESS 0xffc03000
> > #define SOCFPGA_OSC1TIMER0_ADDRESS 0xffd00000
> > +#define SOCFPGA_L4WD0_ADDRESS 0xffd02000
> > #define SOCFPGA_CLKMGR_ADDRESS 0xffd04000
> > #define SOCFPGA_RSTMGR_ADDRESS 0xffd05000
> > #define SOCFPGA_SYSMGR_ADDRESS 0xffd08000
> > diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h
> > index fc921ee..1b78ccb 100644
> > --- a/include/configs/socfpga_cyclone5.h
> > +++ b/include/configs/socfpga_cyclone5.h
> > @@ -207,6 +207,16 @@
> > #define CONFIG_ENV_IS_NOWHERE
> >
> > /*
> > + * L4 Watchdog
> > + */
>
> Why multiline comment here?
Oh its just for easy reading.
>
> > +#define CONFIG_HW_WATCHDOG
> > +#define CONFIG_HW_WATCHDOG_TIMEOUT_MS 2000
> > +#define CONFIG_DESIGNWARE_WATCHDOG
> > +#define CONFIG_DW_WDT_BASE SOCFPGA_L4WD0_ADDRESS
>
> Why not just use SOCFPGA_L4WD0_ADDRESS directly?
Nope, cause this driver might be used by other platform.
Thanks
Chin Liang
>
> Thanks,
> Michal
>
>
next prev parent reply other threads:[~2014-02-27 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 20:57 [U-Boot] [PATCH v3 2/2] socfpga: Adding DesignWare watchdog support Chin Liang See
2014-02-24 7:52 ` Michal Simek
2014-02-27 19:55 ` Chin Liang See [this message]
2014-02-28 10:31 ` Michal Simek
2014-03-04 23:49 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393530953.1993.3.camel@clsee-VirtualBox.altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.