From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v5 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue
Date: Fri, 28 Feb 2014 10:46:01 +0800 [thread overview]
Message-ID: <1393555579-11271-1-git-send-email-quwenruo@cn.fujitsu.com> (raw)
Add a new btrfs_workqueue_struct which use kernel workqueue to implement
most of the original btrfs_workers, to replace btrfs_workers.
With this patchset, redundant workqueue codes are replaced with kernel
workqueue infrastructure, which not only reduces the code size but also the
effort to maintain it.
The result(somewhat outdated though) from sysbench shows minor improvement on the following server:
CPU: two-way Xeon X5660
RAM: 4G
HDD: SAS HDD, 150G total, 100G partition for btrfs test
Test result on default mount option:
https://docs.google.com/spreadsheet/ccc?key=0AhpkL3ehzX3pdENjajJTWFg5d1BWbExnYWFpMTJxeUE&usp=sharing
Test result on "-o compress" mount option:
https://docs.google.com/spreadsheet/ccc?key=0AhpkL3ehzX3pdHdTTEJ6OW96SXJFaDR5enB1SzMzc0E&usp=sharing
Changelog:
v1->v2:
- Fix some workqueue flags.
v2->v3:
- Add the thresholding mechanism to simulate the old behavior
- Convert all the btrfs_workers to btrfs_workrqueue_struct.
- Fix some potential deadlock when executed in IRQ handler.
v3->v4:
- Change the ordered workqueue implement to fix the performance drop in 32K
multi thread random write.
- Change the high priority workqueue implement to get an independent high
workqueue without starving problem.
- Simplify the btrfs_alloc_workqueue parameters.
- Coding style cleanup.
- Remove the redundant "_struct" suffix.
v4->v5:
- Fix a multithread free-and-use bug reported by Josef and David.
Qu Wenruo (18):
btrfs: Cleanup the unused struct async_sched.
btrfs: Added btrfs_workqueue_struct implemented ordered execution
based on kernel workqueue
btrfs: Add high priority workqueue support for btrfs_workqueue_struct
btrfs: Add threshold workqueue based on kernel workqueue
btrfs: Replace fs_info->workers with btrfs_workqueue.
btrfs: Replace fs_info->delalloc_workers with btrfs_workqueue
btrfs: Replace fs_info->submit_workers with btrfs_workqueue.
btrfs: Replace fs_info->flush_workers with btrfs_workqueue.
btrfs: Replace fs_info->endio_* workqueue with btrfs_workqueue.
btrfs: Replace fs_info->rmw_workers workqueue with btrfs_workqueue.
btrfs: Replace fs_info->cache_workers workqueue with btrfs_workqueue.
btrfs: Replace fs_info->readahead_workers workqueue with
btrfs_workqueue.
btrfs: Replace fs_info->fixup_workers workqueue with btrfs_workqueue.
btrfs: Replace fs_info->delayed_workers workqueue with
btrfs_workqueue.
btrfs: Replace fs_info->qgroup_rescan_worker workqueue with
btrfs_workqueue.
btrfs: Replace fs_info->scrub_* workqueue with btrfs_workqueue.
btrfs: Cleanup the old btrfs_worker.
btrfs: Cleanup the "_struct" suffix in btrfs_workequeue
fs/btrfs/async-thread.c | 830 ++++++++++++-----------------------------------
fs/btrfs/async-thread.h | 119 ++-----
fs/btrfs/ctree.h | 39 ++-
fs/btrfs/delayed-inode.c | 6 +-
fs/btrfs/disk-io.c | 212 +++++-------
fs/btrfs/extent-tree.c | 4 +-
fs/btrfs/inode.c | 38 +--
fs/btrfs/ordered-data.c | 11 +-
fs/btrfs/qgroup.c | 15 +-
fs/btrfs/raid56.c | 21 +-
fs/btrfs/reada.c | 4 +-
fs/btrfs/scrub.c | 70 ++--
fs/btrfs/super.c | 36 +-
fs/btrfs/volumes.c | 16 +-
14 files changed, 446 insertions(+), 975 deletions(-)
--
1.9.0
next reply other threads:[~2014-02-28 2:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 2:46 Qu Wenruo [this message]
2014-02-28 2:46 ` [PATCH v5 01/18] btrfs: Cleanup the unused struct async_sched Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 02/18] btrfs: Added btrfs_workqueue_struct implemented ordered execution based on kernel workqueue Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 03/18] btrfs: Add high priority workqueue support for btrfs_workqueue_struct Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 04/18] btrfs: Add threshold workqueue based on kernel workqueue Qu Wenruo
2015-08-19 16:46 ` Alex Lyakas
2015-08-20 1:07 ` Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 05/18] btrfs: Replace fs_info->workers with btrfs_workqueue Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 06/18] btrfs: Replace fs_info->delalloc_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 07/18] btrfs: Replace fs_info->submit_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 08/18] btrfs: Replace fs_info->flush_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 09/18] btrfs: Replace fs_info->endio_* workqueue " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 10/18] btrfs: Replace fs_info->rmw_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 11/18] btrfs: Replace fs_info->cache_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 12/18] btrfs: Replace fs_info->readahead_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 13/18] btrfs: Replace fs_info->fixup_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 14/18] btrfs: Replace fs_info->delayed_workers " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 15/18] btrfs: Replace fs_info->qgroup_rescan_worker " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 16/18] btrfs: Replace fs_info->scrub_* " Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 17/18] btrfs: Cleanup the old btrfs_worker Qu Wenruo
2014-02-28 2:46 ` [PATCH v5 18/18] btrfs: Cleanup the "_struct" suffix in btrfs_workequeue Qu Wenruo
2014-03-11 13:51 ` [PATCH v5 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue Filipe David Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393555579-11271-1-git-send-email-quwenruo@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.