[PATCH] staging: dgap: Fix format string mismatch in downld.c

[PATCH] staging: dgap: Fix format string mismatch in downld.c

[Masanari Iida]

req_type and bdid in struct downldio are defined as unsigned int.
So dlio.req_type and dlio.bdid have to be unsigned int,too.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/staging/dgap/downld.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dgap/downld.c b/drivers/staging/dgap/downld.c
index 1f4aa2e..a71a69b 100644
--- a/drivers/staging/dgap/downld.c
+++ b/drivers/staging/dgap/downld.c
@@ -436,7 +436,7 @@ int main(int argc, char **argv)
 			sleep(2);
 		} else {
 			if (debugflag)
-				printf("dlio.req_type is %d bd %d\n",
+				printf("dlio.req_type is %u bd %u\n",
 					dlio.req_type,dlio.bdid);
 
 			switch(dlio.req_type) {
@@ -596,7 +596,7 @@ int main(int argc, char **argv)
 #if 0
 					sprintf(string, "%s /proc/dgap/%d/mknod", DEFSHELL, dlio.bdid);
 #endif
-					sprintf(string, "%s /usr/sbin/dgap_updatedevs %d", DEFSHELL, dlio.bdid);
+					sprintf(string, "%s /usr/sbin/dgap_updatedevs %u", DEFSHELL, dlio.bdid);
 					system(string);
 
 					if (debugflag)
-- 
1.9.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgap: Fix format string mismatch in downld.c

[Greg KH]

On Fri, Feb 28, 2014 at 08:10:14PM +0900, Masanari Iida wrote:
> req_type and bdid in struct downldio are defined as unsigned int.
> So dlio.req_type and dlio.bdid have to be unsigned int,too.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  drivers/staging/dgap/downld.c | 4 ++--

This file isn't in my tree anymore, what kernel did you make this patch
against?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgap: Fix format string mismatch in downld.c

[Mark Hounschell]

On 02/28/2014 06:10 AM, Masanari Iida wrote:
> req_type and bdid in struct downldio are defined as unsigned int.
> So dlio.req_type and dlio.bdid have to be unsigned int,too.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>   drivers/staging/dgap/downld.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgap/downld.c b/drivers/staging/dgap/downld.c
> index 1f4aa2e..a71a69b 100644
> --- a/drivers/staging/dgap/downld.c
> +++ b/drivers/staging/dgap/downld.c
> @@ -436,7 +436,7 @@ int main(int argc, char **argv)
>   			sleep(2);
>   		} else {
>   			if (debugflag)
> -				printf("dlio.req_type is %d bd %d\n",
> +				printf("dlio.req_type is %u bd %u\n",
>   					dlio.req_type,dlio.bdid);
>
>   			switch(dlio.req_type) {
> @@ -596,7 +596,7 @@ int main(int argc, char **argv)
>   #if 0
>   					sprintf(string, "%s /proc/dgap/%d/mknod", DEFSHELL, dlio.bdid);
>   #endif
> -					sprintf(string, "%s /usr/sbin/dgap_updatedevs %d", DEFSHELL, dlio.bdid);
> +					sprintf(string, "%s /usr/sbin/dgap_updatedevs %u", DEFSHELL, dlio.bdid);
>   					system(string);
>
>   					if (debugflag)
>

FYI, drivers/staging/dgap/downld.c was the source for a userland 
application used to load firmware into the boards. It is no longer in 
the repo and firmware loading is now done in kernel.

Regards
Mark
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel