From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbaCGDAB (ORCPT ); Thu, 6 Mar 2014 22:00:01 -0500 Received: from gate.crashing.org ([63.228.1.57]:56467 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbaCGC7d (ORCPT ); Thu, 6 Mar 2014 21:59:33 -0500 Message-ID: <1394161051.26321.71.camel@pasglop> Subject: Re: [PATCH v2 14/52] powerpc, sysfs: Fix CPU hotplug callback registration From: Benjamin Herrenschmidt To: "Srivatsa S. Bhat" Cc: paulus@samba.org, oleg@redhat.com, mingo@kernel.org, rusty@rustcorp.com.au, peterz@infradead.org, tglx@linutronix.de, akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com, tj@kernel.org, walken@google.com, ego@linux.vnet.ibm.com, linux@arm.linux.org.uk, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Olof Johansson , Wang Dongsheng , linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Date: Fri, 07 Mar 2014 13:57:31 +1100 In-Reply-To: <20140214075215.22701.23653.stgit@srivatsabhat.in.ibm.com> References: <20140214074750.22701.47330.stgit@srivatsabhat.in.ibm.com> <20140214075215.22701.23653.stgit@srivatsabhat.in.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.11.90 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-02-14 at 13:22 +0530, Srivatsa S. Bhat wrote: > Subsystems that want to register CPU hotplug callbacks, as well as perform > initialization for the CPUs that are already online, often do it as shown > below: > > get_online_cpus(); > > for_each_online_cpu(cpu) > init_cpu(cpu); > > register_cpu_notifier(&foobar_cpu_notifier); > > put_online_cpus(); This patch breaks a good half of my test configs with: /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c: In function 'topology_init': /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c:979:2: error: implicit declaration of function 'cpu_notifier_register_begin' [-Werror=implicit-function-declaration] /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c:1004:2: error: implicit declaration of function '__register_cpu_notifier' [-Werror=implicit-function-declaration] /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c:1006:2: error: implicit declaration of function 'cpu_notifier_register_done' [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors make[2]: *** [arch/powerpc/kernel/sysfs.o] Error 1 make[2]: *** Waiting for unfinished jobs.... From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v2 14/52] powerpc, sysfs: Fix CPU hotplug callback registration Date: Fri, 07 Mar 2014 13:57:31 +1100 Message-ID: <1394161051.26321.71.camel@pasglop> References: <20140214074750.22701.47330.stgit@srivatsabhat.in.ibm.com> <20140214075215.22701.23653.stgit@srivatsabhat.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140214075215.22701.23653.stgit@srivatsabhat.in.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: "Srivatsa S. Bhat" Cc: linux-arch@vger.kernel.org, ego@linux.vnet.ibm.com, walken@google.com, linux@arm.linux.org.uk, akpm@linux-foundation.org, Wang Dongsheng , peterz@infradead.org, rusty@rustcorp.com.au, rjw@rjwysocki.net, oleg@redhat.com, linux-kernel@vger.kernel.org, Olof Johansson , Madhavan Srinivasan , paulus@samba.org, tj@kernel.org, tglx@linutronix.de, paulmck@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org List-Id: linux-arch.vger.kernel.org T24gRnJpLCAyMDE0LTAyLTE0IGF0IDEzOjIyICswNTMwLCBTcml2YXRzYSBTLiBCaGF0IHdyb3Rl Ogo+IFN1YnN5c3RlbXMgdGhhdCB3YW50IHRvIHJlZ2lzdGVyIENQVSBob3RwbHVnIGNhbGxiYWNr cywgYXMgd2VsbCBhcyBwZXJmb3JtCj4gaW5pdGlhbGl6YXRpb24gZm9yIHRoZSBDUFVzIHRoYXQg YXJlIGFscmVhZHkgb25saW5lLCBvZnRlbiBkbyBpdCBhcyBzaG93bgo+IGJlbG93Ogo+IAo+IAln ZXRfb25saW5lX2NwdXMoKTsKPiAKPiAJZm9yX2VhY2hfb25saW5lX2NwdShjcHUpCj4gCQlpbml0 X2NwdShjcHUpOwo+IAo+IAlyZWdpc3Rlcl9jcHVfbm90aWZpZXIoJmZvb2Jhcl9jcHVfbm90aWZp ZXIpOwo+IAo+IAlwdXRfb25saW5lX2NwdXMoKTsKClRoaXMgcGF0Y2ggYnJlYWtzIGEgZ29vZCBo YWxmIG9mIG15IHRlc3QgY29uZmlncyB3aXRoOgoKL2hvbWUvYmVuaC9saW51eC1wb3dlcnBjLXRl c3QvYXJjaC9wb3dlcnBjL2tlcm5lbC9zeXNmcy5jOiBJbiBmdW5jdGlvbiAndG9wb2xvZ3lfaW5p dCc6Ci9ob21lL2JlbmgvbGludXgtcG93ZXJwYy10ZXN0L2FyY2gvcG93ZXJwYy9rZXJuZWwvc3lz ZnMuYzo5Nzk6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uICdjcHVf bm90aWZpZXJfcmVnaXN0ZXJfYmVnaW4nIFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xh cmF0aW9uXQovaG9tZS9iZW5oL2xpbnV4LXBvd2VycGMtdGVzdC9hcmNoL3Bvd2VycGMva2VybmVs L3N5c2ZzLmM6MTAwNDoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g J19fcmVnaXN0ZXJfY3B1X25vdGlmaWVyJyBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNs YXJhdGlvbl0KL2hvbWUvYmVuaC9saW51eC1wb3dlcnBjLXRlc3QvYXJjaC9wb3dlcnBjL2tlcm5l bC9zeXNmcy5jOjEwMDY6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9u ICdjcHVfbm90aWZpZXJfcmVnaXN0ZXJfZG9uZScgWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24t ZGVjbGFyYXRpb25dCmNjMTogYWxsIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCm1h a2VbMl06ICoqKiBbYXJjaC9wb3dlcnBjL2tlcm5lbC9zeXNmcy5vXSBFcnJvciAxCm1ha2VbMl06 ICoqKiBXYWl0aW5nIGZvciB1bmZpbmlzaGVkIGpvYnMuLi4uCgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QK TGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xp c3RpbmZvL2xpbnV4cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 64C8D2C032B for ; Fri, 7 Mar 2014 13:59:07 +1100 (EST) Message-ID: <1394161051.26321.71.camel@pasglop> Subject: Re: [PATCH v2 14/52] powerpc, sysfs: Fix CPU hotplug callback registration From: Benjamin Herrenschmidt To: "Srivatsa S. Bhat" Date: Fri, 07 Mar 2014 13:57:31 +1100 In-Reply-To: <20140214075215.22701.23653.stgit@srivatsabhat.in.ibm.com> References: <20140214074750.22701.47330.stgit@srivatsabhat.in.ibm.com> <20140214075215.22701.23653.stgit@srivatsabhat.in.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linux-arch@vger.kernel.org, ego@linux.vnet.ibm.com, walken@google.com, linux@arm.linux.org.uk, akpm@linux-foundation.org, Wang Dongsheng , peterz@infradead.org, rusty@rustcorp.com.au, rjw@rjwysocki.net, oleg@redhat.com, linux-kernel@vger.kernel.org, Olof Johansson , Madhavan Srinivasan , paulus@samba.org, tj@kernel.org, tglx@linutronix.de, paulmck@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2014-02-14 at 13:22 +0530, Srivatsa S. Bhat wrote: > Subsystems that want to register CPU hotplug callbacks, as well as perform > initialization for the CPUs that are already online, often do it as shown > below: > > get_online_cpus(); > > for_each_online_cpu(cpu) > init_cpu(cpu); > > register_cpu_notifier(&foobar_cpu_notifier); > > put_online_cpus(); This patch breaks a good half of my test configs with: /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c: In function 'topology_init': /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c:979:2: error: implicit declaration of function 'cpu_notifier_register_begin' [-Werror=implicit-function-declaration] /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c:1004:2: error: implicit declaration of function '__register_cpu_notifier' [-Werror=implicit-function-declaration] /home/benh/linux-powerpc-test/arch/powerpc/kernel/sysfs.c:1006:2: error: implicit declaration of function 'cpu_notifier_register_done' [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors make[2]: *** [arch/powerpc/kernel/sysfs.o] Error 1 make[2]: *** Waiting for unfinished jobs....