From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Support for btrfs in pv-grub Date: Tue, 11 Mar 2014 10:58:31 +0000 Message-ID: <1394535511.18366.35.camel@kazak.uk.xensource.com> References: <530E0F7E02000091000B8C20@prv-mh.provo.novell.com> <1393555348.20365.11.camel@hastur.hellion.org.uk> <20140228033029.GA14114@u109add4315675089e695.ant.amazon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140228033029.GA14114@u109add4315675089e695.ant.amazon.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matt Wilson Cc: Charles Arnold , Ian Jackson , Matt Wilson , xen-devel List-Id: xen-devel@lists.xenproject.org On Thu, 2014-02-27 at 19:30 -0800, Matt Wilson wrote: > On Fri, Feb 28, 2014 at 02:42:28AM +0000, Ian Campbell wrote: > > On Wed, 2014-02-26 at 15:59 -0700, Charles Arnold wrote: > > > Code to support btrfs in pv-grub was added almost two years ago (c/s 25154). > > > > Ccing the author. > > > > > Building the code doesn't seem to be enabled in stubdom/grub/Makefile. > > > Was this functionality ever intended to work? > > > > One would like to assume so! > > > > > Does anyone know the status of this code? > > > > Matt? > > > > Looks like Makefile.am was patched but not Makefile.in, and I don't > > think we run automake as part of the stubdom build process. > > True, but we also don't use the Makefiles in grub-upstream to build > GRUB. We use xen/stubdom/grub/Makefile, which also isn't patched to > build the btrfs code. So this code was untested when it was submitted and you aren't using it today? > Unfortunately when I added it grub/Makefile, it doesn't build on a > modern compiler. > > Do you think we should revert the patch that adds btrfs support? Unless someone is going to fix it up up as Charles suggests then it seems misleading to keep it in the code base. Ian.