From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH-4.5 v2 02/10] xen/arm: support HW interrupts in gic_set_lr Date: Tue, 18 Mar 2014 17:47:42 +0000 Message-ID: <1395164862.11824.59.camel@kazak.uk.xensource.com> References: <1392393098-7351-2-git-send-email-stefano.stabellini@eu.citrix.com> <52FE5729.1050906@linaro.org> <1395158491.12847.76.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: julien.grall@citrix.com, Julien Grall , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, 2014-03-18 at 17:38 +0000, Stefano Stabellini wrote: > On Tue, 18 Mar 2014, Ian Campbell wrote: > > On Fri, 2014-02-14 at 17:49 +0000, Julien Grall wrote: > > > On 02/14/2014 03:51 PM, Stefano Stabellini wrote: > > > > If the irq to be injected is an hardware irq (p->desc != NULL), set > > > > GICH_LR_HW. > > > > > > > > Remove the code to EOI a physical interrupt on behalf of the guest > > > > because it has become unnecessary. > > > > > > > > Also add a struct vcpu* parameter to gic_set_lr. > > > > > > > > Signed-off-by: Stefano Stabellini > > > > > > IRL you told me that this patch as dependency on another. It would be > > > nice to mention this dependency in the commit message for bisection. > > > > As in bisection is broken and needs manual intervention? Please don't do > > that, reorder it or resplit things to make the issue go away. > > > > The patch itself looks ok to me, but I won't ack until this is explained > > or resolved. > > Patch #2 and #3 should really be applied together, I separated them out > just for the sake of readibility. The reason is that you can't receive > maintenance interrupts for hw interrupts, so in order for this to work > properly we need the following patch "do not request > maintenance_interrupts". > > I can send them as a single patch next time, but it would be harder to > review. I think it'll be ok and/or we'll have to live with it. Ian.