From: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org> To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>, Fabrice Crohas <fcrohas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Illia Smyrnov <illia.smyrnov-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>, Atsushi Nemoto <anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 1/7] spi: core: Validate Tx/Rx buffers for non-zero length transfer Date: Wed, 19 Mar 2014 11:53:47 +0800 [thread overview] Message-ID: <1395201227.16346.1.camel@phoenix> (raw) Reject transfer if both tx_buf and rx_buf are NULL for non-zero length transfer. Add the checking in spi core so we can remove the same checking in various drivers. Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org> --- drivers/spi/spi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 26b331d..0a29d2a 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1876,6 +1876,10 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message) if (xfer->len % w_size) return -EINVAL; + /* non-zero length transfer must has tx_buf or rx_buf */ + if (xfer->len && !xfer->tx_buf && !xfer->rx_buf) + return -EINVAL; + if (xfer->speed_hz && master->min_speed_hz && xfer->speed_hz < master->min_speed_hz) return -EINVAL; -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-03-19 3:53 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-03-19 3:53 Axel Lin [this message] 2014-03-19 3:55 ` [PATCH 2/7] spi: atmel: Let spi core validate " Axel Lin 2014-03-19 4:01 ` Yang, Wenyou 2014-03-19 3:56 ` [PATCH 3/7] spi: omap-100k: " Axel Lin 2014-03-19 3:57 ` [PATCH 4/7] spi: omap2-mcspi: " Axel Lin 2014-03-19 3:58 ` [PATCH 5/7] spi: txx9: " Axel Lin 2014-03-19 3:59 ` [PATCH 6/7] spi: xcomm: " Axel Lin 2014-03-19 7:39 ` Lars-Peter Clausen 2014-03-19 4:00 ` [PATCH 7/7] spi: bitbang: " Axel Lin 2014-03-19 8:06 ` [PATCH 1/7] spi: core: Validate " Geert Uytterhoeven [not found] ` <CAMuHMdWCdp_SW5CNt50cSfG700JRU3tr=Pbyhv8nv-1Ve=XUNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-03-19 15:43 ` Axel Lin [not found] ` <CAFRkauCUUOQ0xxa-k5_TMKUA7jnnz1FPjXnGT4T10v7upyOy8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-03-19 16:08 ` Mark Brown 2014-08-16 14:34 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1395201227.16346.1.camel@phoenix \ --to=axel.lin-8e1dmatc8ynqt0dzr+alfa@public.gmane.org \ --cc=anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=fcrohas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=illia.smyrnov-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org \ --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \ --subject='Re: [PATCH 1/7] spi: core: Validate Tx/Rx buffers for non-zero length transfer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.