All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/7] spi: core: Validate Tx/Rx buffers for non-zero length transfer
@ 2014-03-19  3:53 Axel Lin
  2014-03-19  3:55 ` [PATCH 2/7] spi: atmel: Let spi core validate " Axel Lin
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: Axel Lin @ 2014-03-19  3:53 UTC (permalink / raw)
  To: Mark Brown
  Cc: Wenyou Yang, Fabrice Crohas, Illia Smyrnov, Atsushi Nemoto,
	Lars-Peter Clausen, linux-spi-u79uwXL29TY76Z2rM5mHXA

Reject transfer if both tx_buf and rx_buf are NULL for non-zero length transfer.
Add the checking in spi core so we can remove the same checking in various
drivers.

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/spi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 26b331d..0a29d2a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1876,6 +1876,10 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)
 		if (xfer->len % w_size)
 			return -EINVAL;
 
+		/* non-zero length transfer must has tx_buf or rx_buf */
+		if (xfer->len && !xfer->tx_buf && !xfer->rx_buf)
+			return -EINVAL;
+
 		if (xfer->speed_hz && master->min_speed_hz &&
 		    xfer->speed_hz < master->min_speed_hz)
 			return -EINVAL;
-- 
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2014-08-16 14:34 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-19  3:53 [PATCH 1/7] spi: core: Validate Tx/Rx buffers for non-zero length transfer Axel Lin
2014-03-19  3:55 ` [PATCH 2/7] spi: atmel: Let spi core validate " Axel Lin
2014-03-19  4:01   ` Yang, Wenyou
2014-03-19  3:56 ` [PATCH 3/7] spi: omap-100k: " Axel Lin
2014-03-19  3:57 ` [PATCH 4/7] spi: omap2-mcspi: " Axel Lin
2014-03-19  3:58 ` [PATCH 5/7] spi: txx9: " Axel Lin
2014-03-19  3:59 ` [PATCH 6/7] spi: xcomm: " Axel Lin
2014-03-19  7:39   ` Lars-Peter Clausen
2014-03-19  4:00 ` [PATCH 7/7] spi: bitbang: " Axel Lin
2014-03-19  8:06 ` [PATCH 1/7] spi: core: Validate " Geert Uytterhoeven
     [not found]   ` <CAMuHMdWCdp_SW5CNt50cSfG700JRU3tr=Pbyhv8nv-1Ve=XUNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-19 15:43     ` Axel Lin
     [not found]       ` <CAFRkauCUUOQ0xxa-k5_TMKUA7jnnz1FPjXnGT4T10v7upyOy8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-19 16:08         ` Mark Brown
2014-08-16 14:34     ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.