All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Capella <sebastian.capella@linaro.org>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linaro-kernel@lists.linaro.org
Subject: [PATCH RFC 0/1] PM / Hibernate: no kernel_power_off when pm_power_off
Date: Thu, 20 Mar 2014 13:53:14 -0700	[thread overview]
Message-ID: <1395348795-8554-1-git-send-email-sebastian.capella@linaro.org> (raw)

Patch to avoid calling kernel_power_off when pm_power_off is null.
When pm_power_off is null, the platform will not power off in
kernel_power_off.  Currently, hibernate will call kernel_power_off and
then move on to kernel_halt.  However, this calls the notifier chain
twice with a different parameter.  In kernel/reboot.c, this is avoided
by checking if pm_power_off is NULL and bypassing kernel_power_off.

Mostly, this is a check if anyone is dependent on having the reboot
notifier called 2x if pm_power_off is null.  There are some panics if
it's called this way in some drivers.

Tested this on omap beaglebone black, but have not tried on other
hardware.  Please let me know if you can test this on another platform
and the results.

Thanks,

Sebastian

             reply	other threads:[~2014-03-20 20:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 20:53 Sebastian Capella [this message]
2014-03-20 20:53 ` [PATCH RFC] PM / Hibernate: no kernel_power_off when pm_power_off NULL Sebastian Capella
2014-03-20 21:23   ` Pavel Machek
2014-03-20 21:35     ` One Thousand Gnomes
2014-03-20 21:36       ` Sebastian Capella
2014-03-26 17:22         ` Sebastian Capella
2014-04-15 18:34           ` Sebastian Capella
2014-04-15 20:54             ` Russell King - ARM Linux
2014-04-15 21:18               ` Pavel Machek
2014-04-16 16:28                 ` Sebastian Capella
2014-04-16 20:41                   ` Russell King - ARM Linux
2014-04-16 20:57                     ` One Thousand Gnomes
2014-04-16 21:09                       ` Russell King - ARM Linux
2014-04-18 21:38                         ` Sebastian Capella
2014-04-20 14:06                           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395348795-8554-1-git-send-email-sebastian.capella@linaro.org \
    --to=sebastian.capella@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.