All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v2 2/4] import enable-xen-config from xen.git, use for ts-kernel-build
Date: Fri, 21 Mar 2014 12:09:11 +0000	[thread overview]
Message-ID: <1395403751.27358.74.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1395331361.3104.22.camel@kazak.uk.xensource.com>

On Thu, 2014-03-20 at 16:02 +0000, Ian Campbell wrote:
> On Thu, 2014-03-20 at 16:01 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST v2 2/4] import enable-xen-config from xen.git, use for ts-kernel-build"):
> > > I plan to remove it from xen.git. Take the version from a03984e7bcdf which
> > > hasn't changed since 8dedf6431393 in 2010.
> > > 
> > > Update ts-kernel-build to not require xen.git.
> > > 
> > > config_intree_buildconfigs was unused so remove it.
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > Although:
> > 
> > > +    target_putfilecontents_stash($ho,1000,enable_xen_config(),"$builddir/enable-xen-config");
> > 
> > Firstly, that line could do with wrapping, and secondly, do you really
> > expect this to take 1ks ?  100s seems more like it ...
> 
> 1000 came from the line I cargo culted it from ;-)
> 
> I'll wrap and reduce to 100 as I commit, unless your comments elsewhere
> necessitate a resend anyway.

You acked everything else, so I applied making these changes as I went.

  reply	other threads:[~2014-03-21 12:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 11:45 [PATCH OSSTEST+xen 0/4+1] remove xen.git Linux kernel build integration Ian Campbell
2014-03-19 11:47 ` [PATCH OSSTEST 1/4] mfi-common: remove xen_kernels runvar from build-*-pvops Ian Campbell
2014-03-19 12:06   ` Ian Jackson
2014-03-19 11:47 ` [PATCH OSSTEST 2/4] import enable-xen-config from xen.git, use for ts-kernel-build Ian Campbell
2014-03-19 12:09   ` Ian Jackson
2014-03-19 12:22     ` Ian Campbell
2014-03-19 11:47 ` [PATCH OSSTEST 3/4] Use ts-kernel-build for build-*-oldkern Ian Campbell
2014-03-19 12:12   ` Ian Jackson
2014-03-19 12:26     ` Ian Campbell
2014-03-19 13:28       ` Ian Jackson
2014-03-19 13:37         ` Ian Campbell
2014-03-19 13:46           ` Ian Jackson
2014-03-19 13:51             ` Ian Campbell
2014-03-19 13:35       ` Jan Beulich
2014-03-19 11:47 ` [PATCH OSSTEST 4/4] ts-xen-build: Drop ability to build kernels Ian Campbell
2014-03-19 12:15   ` Ian Jackson
2014-03-19 12:27     ` Ian Campbell
2014-03-19 11:48 ` [PATCH xen.git 1/1] build: remove Linux kernel build integration Ian Campbell
2014-03-26 16:55   ` Ian Campbell
2014-03-26 17:06     ` Jan Beulich
2014-04-03 16:36       ` Ian Campbell
2014-04-08 14:55   ` Ian Jackson
2014-04-08 15:11     ` Ian Campbell
2014-04-08 15:37       ` [PATCH xen.git v2] " Ian Campbell
2014-04-10 11:37         ` Ian Campbell
2014-03-20 15:56 ` [PATCH OSSTEST v2 1/4] mfi-common: remove xen_kernels runvar from build-*-pvops Ian Campbell
2014-03-20 15:56 ` [PATCH OSSTEST v2 2/4] import enable-xen-config from xen.git, use for ts-kernel-build Ian Campbell
2014-03-20 16:01   ` Ian Jackson
2014-03-20 16:02     ` Ian Campbell
2014-03-21 12:09       ` Ian Campbell [this message]
2014-03-20 15:56 ` [PATCH OSSTEST v2 3/4] Use ts-kernel-build for build-*-oldkern Ian Campbell
2014-03-20 16:01   ` Ian Jackson
2014-03-20 15:56 ` [PATCH OSSTEST v2 4/4] ts-xen-build: Drop ability to build kernels Ian Campbell
2014-03-20 16:02   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395403751.27358.74.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.