From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH 37/54] sc92031: Call dev_consume_skb_any instead of dev_kfree_skb. Date: Tue, 25 Mar 2014 13:39:13 -0700 Message-ID: <1395779953.12610.167.camel@edumazet-glaptop2.roam.corp.google.com> References: <87y4zyhlar.fsf_-_@x220.int.ebiederm.org> <1395727540-12148-1-git-send-email-ebiederm@xmission.com> <1395727540-12148-37-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, xiyou.wangcong@gmail.com, mpm@selenic.com, satyam.sharma@gmail.com To: "Eric W. Biederman" Return-path: Received: from mail-pb0-f47.google.com ([209.85.160.47]:57852 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752825AbaCYUjP (ORCPT ); Tue, 25 Mar 2014 16:39:15 -0400 Received: by mail-pb0-f47.google.com with SMTP id up15so963843pbc.6 for ; Tue, 25 Mar 2014 13:39:14 -0700 (PDT) In-Reply-To: <1395727540-12148-37-git-send-email-ebiederm@xmission.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2014-03-24 at 23:05 -0700, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > Replace dev_kfree_skb with dev_consume_skb_any in sc92031_start_xmit > that can be called in hard irq and other contexts. > > Using dev_consume_skb_any preserves the current semantics (as > dev_kfree_skb is just consume_skb) and since packet drops > are rare is usually accurate. > > Signed-off-by: "Eric W. Biederman" > --- Acked-by: Eric Dumazet