From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [RFC PATCH v1 03/10] xen/arm: move vgic data to
	vgic driver
Date: Wed, 26 Mar 2014 12:00:33 +0000
Message-ID: <1395835233.4928.7.camel@kazak.uk.xensource.com>
References: <1395238631-2024-1-git-send-email-vijay.kilari@gmail.com>
	<1395238631-2024-4-git-send-email-vijay.kilari@gmail.com>
	<532AF273.3020301@linaro.org>
	<1395422598.25521.48.camel@kazak.uk.xensource.com>
	<CALicx6tJRpukKpqK1hGPXfbErhPMCUstYsP92AgVgBo4gJPnUg@mail.gmail.com>
	<1395658667.19365.46.camel@kazak.uk.xensource.com>
	<CALicx6u75BKQE2FctNULrsgpC6b-qj8EYrN4ANBwkV7Rboa5gQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6u75BKQE2FctNULrsgpC6b-qj8EYrN4ANBwkV7Rboa5gQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-03-26 at 17:14 +0530, Vijay Kilari wrote:
> > If that is the case then I don't think there is any reason to split this
> > struct into v2 and v3 versions. Just keep a single struct with the
> > larger itargets using v3 semantics and have the v2 driver do the obvious
> > packing and unpacking.
> >
>   The complete vgic driver is based on this structure and with change in size
> and number of registers for itargets register is not clean enough to manage
> single vgic driver for both v2 & v3.

What does "not clean enough" mean?

BTW I was suggesting a common datastructure, not a single driver.

Ian.