From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2802FC433B4 for ; Thu, 15 Apr 2021 19:34:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DA47610EA for ; Thu, 15 Apr 2021 19:34:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DA47610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX7kx-0007Bd-4N for qemu-devel@archiver.kernel.org; Thu, 15 Apr 2021 15:34:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7kA-0006gG-L3 for qemu-devel@nongnu.org; Thu, 15 Apr 2021 15:33:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7k8-0006vE-6H for qemu-devel@nongnu.org; Thu, 15 Apr 2021 15:33:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618515214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNFaIwOrUyYhklOPnp1cguu2CWnjxYkJQw3F6YghBp8=; b=btDo1/Ef2llWE44TClNY2LiFAkoZVdp6qyagrnrTtvN3m1WqWCEixdC4lInCMLs6ECnqOg tpY3wkLr+9xRLrkCd8P542VLiK4Ozc/WUdAabth7pEFdIaZXrvgJFg0ucmt6mi+RCuel4K zBitUnkBXfShzGYJflKpRaDZ9APFecQ= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-jGw3XIiYMFCQHiEPJc8sFA-1; Thu, 15 Apr 2021 15:33:32 -0400 X-MC-Unique: jGw3XIiYMFCQHiEPJc8sFA-1 Received: by mail-oi1-f199.google.com with SMTP id r204-20020aca44d50000b029013da91480a0so8191838oia.17 for ; Thu, 15 Apr 2021 12:33:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lNFaIwOrUyYhklOPnp1cguu2CWnjxYkJQw3F6YghBp8=; b=XiVoxKS0Tqc5Y/VlWJVoxZ3rsfQMmgGkhh/JYq2/LfOyH4tCxYXlHSZstRHMmI33iE Uco/9FF7iOmR8gYX+SPYpq79IHEHLPlRFgrn7zCPXRLcV4T1PmyoCMEwUcBR3uctH5Ls jkTkh57t2b8wWTuygxSKJgaAORNsf6W1y9tAGdezjzR5rn62H3E3fKKxPKtxqcl9uBKV zgqhp7A1uf9p6oTX0SXUfpUziib7LvEyBXAJgYBNVoyaSMyeS2JJWMWbGuyaSqdESNbz FuL4ykGXlQxYo9pVsEZrlICBHV4kqUh7pzxTuzG/P7oJeJZPb0HOsULKN6JP0YS3Sdpl iCUw== X-Gm-Message-State: AOAM533wOAFkSAJGUwN0J//pqHtN4KBB1tEXMaFusAttYhQRqNAbjAHa zGX9nWQzQIwEGx7wtnUUrKfg2VCfYdsTmxBOMwZP5xcs8mQjLddnl9MmdhRTc+Jy9BNYn175WNj lrT2NmWEZEo47l1I= X-Received: by 2002:aca:308a:: with SMTP id w132mr3801660oiw.110.1618515211861; Thu, 15 Apr 2021 12:33:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpIjFqmVw82dhGsA3mQO4JoV/57d0FfLpLhygFsUIz1bBUfgyuktqrmVniyF72eQ/GUohOzw== X-Received: by 2002:aca:308a:: with SMTP id w132mr3801647oiw.110.1618515211630; Thu, 15 Apr 2021 12:33:31 -0700 (PDT) Received: from [192.168.0.173] (ip68-103-222-6.ks.ok.cox.net. [68.103.222.6]) by smtp.gmail.com with ESMTPSA id l22sm815267oib.15.2021.04.15.12.33.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 12:33:31 -0700 (PDT) Subject: Re: [PATCH 0/5] block, migration: improve debugging of migration bdrv_flush failure To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20210415135851.862406-1-berrange@redhat.com> From: Connor Kuehl Message-ID: <1395f960-2620-9361-4bb1-25f3a620c756@redhat.com> Date: Thu, 15 Apr 2021 14:33:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210415135851.862406-1-berrange@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ckuehl@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=ckuehl@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Juan Quintela , Richard Henderson , "Dr. David Alan Gilbert" , Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/15/21 8:58 AM, Daniel P. Berrangé wrote: > I spent a while debugging a tricky migration failure today which was > ultimately caused by fdatasync() getting EACCESS. The existing probes > were not sufficient to diagnose this, so I had to resort to GDB. This > improves probes and block error reporting to make future diagnosis > possible without GDB. > > Daniel P. Berrangé (5): > migration: add trace point when vm_stop_force_state fails > softmmu: add trace point when bdrv_flush_all fails > block: preserve errno from fdatasync failures > block: add trace point when fdatasync fails > block: remove duplicate trace.h include > > block/file-posix.c | 10 +++++----- > block/trace-events | 1 + > migration/migration.c | 1 + > migration/trace-events | 1 + > softmmu/cpus.c | 7 ++++++- > softmmu/trace-events | 3 +++ > 6 files changed, 17 insertions(+), 6 deletions(-) > For the series: Reviewed-by: Connor Kuehl