From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 26/34] xen/arm: traps: Drop dump_guest_s1_walk Date: Wed, 2 Apr 2014 09:38:27 +0100 Message-ID: <1396427907.8667.256.camel@kazak.uk.xensource.com> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> <1395766541-23979-27-git-send-email-julien.grall@linaro.org> <1395940176.22909.221.camel@kazak.uk.xensource.com> <533AF073.1040709@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVGgq-0006N0-5T for xen-devel@lists.xenproject.org; Wed, 02 Apr 2014 08:38:32 +0000 In-Reply-To: <533AF073.1040709@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2014-04-01 at 17:59 +0100, Julien Grall wrote: > On 03/27/2014 05:09 PM, Ian Campbell wrote: > > On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote: > >> This function is not used neither export. > > > > I have used it when debugging stuff, where it is very useful. > > I was not sure if anyone was using it. I can export it in p2m.h. > > I'm also thinking to move this function in p2m.c (which is a best place > for this function). What do you think? It's not really a p2m related function, it's guest stage 1. There isn't really a good home for it I don't think. I suppose it has similarities with dump_p2m_lookup/dump_phy_walk and therefore with the core dump_pt_walk, which would then suggest mm.c as a good home for it. > > Should it not be called from one of the dump_vcpu_state in response to > > an exception which implies a guest translation fault? > > > > No, we inject directly an exception to the guest since few months. So we > don't have to print the p2m. Ah, that's probably when the last caller disappeared. On second thoughts, when debugging I can always rescue the code from the git history, so lets go with your first instinct and remove it. The original patch is: Acked-by: Ian Campbell Ian.