From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVnlZ-0007dR-D0 for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:57:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVnlT-0004qP-8i for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:57:37 -0400 Received: from mail-qg0-x22f.google.com ([2607:f8b0:400d:c04::22f]:40396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVnlT-0004qI-1u for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:57:31 -0400 Received: by mail-qg0-f47.google.com with SMTP id 63so2365801qgz.34 for ; Thu, 03 Apr 2014 12:57:30 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 3 Apr 2014 12:56:39 -0700 Message-Id: <1396555000-8205-26-git-send-email-rth@twiddle.net> In-Reply-To: <1396555000-8205-1-git-send-email-rth@twiddle.net> References: <1396555000-8205-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v3 25/26] tcg-aarch64: Prefer unsigned offsets before signed offsets for ldst List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: claudio.fontana@gmail.com The assembler seems to prefer them, perhaps we should too. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index a538a87..58597e7 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @@ -645,11 +645,6 @@ static void tcg_out_ldst_r(TCGContext *s, TCGMemOp size, AArch64LdstType type, static void tcg_out_ldst(TCGContext *s, TCGMemOp size, AArch64LdstType type, TCGReg rd, TCGReg rn, intptr_t offset) { - if (offset >= -256 && offset < 256) { - tcg_out_ldst_9(s, size, type, rd, rn, offset); - return; - } - /* If the offset is naturally aligned and in range, then we can use the scaled uimm12 encoding */ if (offset >= 0 && !(offset & ((1 << size) - 1))) { @@ -660,6 +655,11 @@ static void tcg_out_ldst(TCGContext *s, TCGMemOp size, AArch64LdstType type, } } + if (offset >= -256 && offset < 256) { + tcg_out_ldst_9(s, size, type, rd, rn, offset); + return; + } + /* Worst-case scenario, move offset to temp register, use reg offset. */ tcg_out_movi(s, TCG_TYPE_I64, TCG_REG_TMP, offset); tcg_out_ldst_r(s, size, type, rd, rn, TCG_REG_TMP); -- 1.9.0