From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWjfN-0004Fd-J5 for qemu-devel@nongnu.org; Sun, 06 Apr 2014 05:47:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWjfH-0004fR-Ef for qemu-devel@nongnu.org; Sun, 06 Apr 2014 05:47:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWjfH-0004fG-55 for qemu-devel@nongnu.org; Sun, 06 Apr 2014 05:46:59 -0400 Date: Sun, 6 Apr 2014 12:47:37 +0300 From: "Michael S. Tsirkin" Message-ID: <1396776125-5419-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, Anthony Liguori ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container Device. Signed-off-by: Michael S. Tsirkin --- Note: Igor has RFC patches to use PNP0C02 under PCI0, but that's not ready for 2.0. Igor, could you comment on whether PNP0C02 is preferable for some OS-es? For PNP0A06 ACPI spec says: PNP0A06 Generic Container Device. This device behaves exactly the same as the PNP0A05 device. This was originally known as Extended I/O Bus. This ID should only be used for containers that do not produce resources for consumption by child devices. Any system resources claimed by a PNP0A06 device=E2=80=99s _CRS object must be consumed by= the container itself. PNP0C02 is not in ACPI spec. It does appear in MicroSoft legacy PNP ID document: PNP0C02 General ID for reserving resources required by Plug a= nd Play motherboard registers. (Not specific to a particular device.) Thoughts? hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-ho= tplug.dsl index dee4843..34aab5a 100644 --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl @@ -93,7 +93,7 @@ Scope(\_SB) { } =20 Device(CPU_HOTPLUG_RESOURCE_DEVICE) { - Name(_HID, "ACPI0004") + Name(_HID, EisaId("PNP0A06")) =20 Name(_CRS, ResourceTemplate() { IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS= _LEN) --=20 MST