All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RFC] spi: efm32: Make "efm32,location" property optional
@ 2014-04-07  3:18 Axel Lin
  2014-04-07  6:16 ` Uwe Kleine-König
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2014-04-07  3:18 UTC (permalink / raw)
  To: Mark Brown; +Cc: Uwe Kleine-König, linux-spi-u79uwXL29TY76Z2rM5mHXA

The spi driver still works even if "efm32,location" property is not provided.
Thus make "efm32,location" property optional.

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
index 8f081c9..33e6040 100644
--- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
+++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt
@@ -8,6 +8,8 @@ Required properties:
 - interrupts: pair specifying rx and tx irq
 - clocks: phandle to the spi clock
 - cs-gpios: see spi-bus.txt
+
+Recommended properties :
 - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
 
 Example:
-- 
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RFC] spi: efm32: Make "efm32,location" property optional
  2014-04-07  3:18 [PATCH RFC] spi: efm32: Make "efm32,location" property optional Axel Lin
@ 2014-04-07  6:16 ` Uwe Kleine-König
  0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2014-04-07  6:16 UTC (permalink / raw)
  To: Axel Lin
  Cc: Mark Brown, Uwe Kleine-König, linux-spi-u79uwXL29TY76Z2rM5mHXA

Hi Axel,

On Mon, Apr 07, 2014 at 11:18:52AM +0800, Axel Lin wrote:
> The spi driver still works even if "efm32,location" property is not provided.
> Thus make "efm32,location" property optional.
good catch. The changelog is wrong though. You don't make the property
optional, you only adapt the documentation to reality. It would be also
nice to mention the default value (i.e. keeping what is already
configured in the hardware, so its either the reset default 0 or
whatever the bootloader did.) OTOH I'm not sure if that should go into
the binding doc as it sounds Linux specific?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-07  6:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-07  3:18 [PATCH RFC] spi: efm32: Make "efm32,location" property optional Axel Lin
2014-04-07  6:16 ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.