From: Johannes Berg <johannes@sipsolutions.net>
To: "Zhao, Gang" <gamerh2o@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/8] cfg80211: fix possible compile warning in wext-compat.h
Date: Wed, 09 Apr 2014 14:46:50 +0200 [thread overview]
Message-ID: <1397047610.4964.14.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <c0bf65125e2d1fce1a1757cd2d46ef47d4a145b9.1397006688.git.gamerh2o@gmail.com> (sfid-20140409_032851_199422_DE76A6CA)
On Wed, 2014-04-09 at 09:28 +0800, Zhao, Gang wrote:
> Function cfg80211_wext_freq() is declared in wext-compat.h, but its
> parameter struct wiphy's declaration is not included there. Actually
> the parameter is not used in this function, so change it to normal
> net_device.
>
> The compile warning doesn't show up due to duplicate including, but
> it's worth fixing it.
Why not just include the right file here?
johannes
next prev parent reply other threads:[~2014-04-09 12:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 1:28 [PATCH 1/8] cfg80211: fix possible compile warning in wext-compat.h Zhao, Gang
2014-04-09 1:28 ` [PATCH 2/8] mac80211: fix possible compile warning in debugfs.h Zhao, Gang
2014-04-09 1:28 ` [PATCH 3/8] mac80211: fix possible compile warning in michael.h Zhao, Gang
2014-04-09 12:47 ` Johannes Berg
2014-04-09 1:28 ` [PATCH 4/8] mac80211: fix possible compile warning in debugfs_netdev.h Zhao, Gang
2014-04-09 12:50 ` Johannes Berg
2014-04-09 1:28 ` [PATCH 5/8] cfg80211: remove unnecessary include clauses (cfg80211.h) Zhao, Gang
2014-04-09 1:28 ` [PATCH 6/8] mac80211: remove unnecessary include clauses (mac80211.h) Zhao, Gang
2014-04-09 1:28 ` [PATCH 7/8] mac80211: remove unnecessary include clauses Zhao, Gang
2014-04-09 1:28 ` [PATCH 8/8] cfg80211: " Zhao, Gang
2014-04-09 7:49 ` Johannes Berg
2014-04-09 12:25 ` Zhao, Gang
2014-04-09 12:36 ` Johannes Berg
2014-04-09 12:43 ` Johannes Berg
2014-04-10 2:37 ` Zhao, Gang
2014-04-09 15:22 ` Zhao, Gang
2014-04-09 13:49 ` Zhao, Gang
2014-04-09 12:46 ` Johannes Berg [this message]
2014-04-09 14:18 ` [PATCH 1/8] cfg80211: fix possible compile warning in wext-compat.h Zhao, Gang
2014-04-10 8:02 ` Johannes Berg
2014-04-10 8:09 ` Johannes Berg
2014-04-11 0:27 ` Zhao, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397047610.4964.14.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gamerh2o@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.