From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 05/15] xen/arm: segregate GIC low level functionality Date: Thu, 10 Apr 2014 09:59:23 +0100 Message-ID: <1397120363.9862.40.camel@kazak.uk.xensource.com> References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com> <1396612593-443-6-git-send-email-vijay.kilari@gmail.com> <533EB9C4.3020709@linaro.org> <1397062800.6275.147.camel@kazak.uk.xensource.com> <53457E34.4010108@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53457E34.4010108@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2014-04-09 at 18:07 +0100, Julien Grall wrote: > If we keep two patch, perhaps the gicv2 callbacks should be prefix by > gicv2_... I think this should be done regardless of everything else. Although it doesn't matter much once the functions are in gic-v2.c it will make it obvious in stack traces etc which driver is in use. Ian.