From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 06/15] xen/arm: move gic lock out of gic
 data structure
Date: Thu, 10 Apr 2014 11:02:32 +0100
Message-ID: <1397124152.9862.91.camel@kazak.uk.xensource.com>
References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com>
	<1396612593-443-7-git-send-email-vijay.kilari@gmail.com>
	<1397119921.9862.35.camel@kazak.uk.xensource.com>
	<CALicx6tLNkxXtWsBNFVtSj7o8X+BmkN9bV1yMbpMnRifbqsqLg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6tLNkxXtWsBNFVtSj7o8X+BmkN9bV1yMbpMnRifbqsqLg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-04-10 at 14:54 +0530, Vijay Kilari wrote:
> On Thu, Apr 10, 2014 at 2:22 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@gmail.com wrote:
> >> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> >>
> >> spinlock is used across generic and GIC low level
> >> functions. Move this lock out of gic data.
> >> This helps to separate generic and low level functions
> >> later.
> >
> > Is there a subsequent patch which exposes this lock to  gic-{v2,v3}.c? I
> > grepped but couldn't find it. AFAIK the pattern is always:
> >         common: take lock
> >         common: call per gic callback
> >                 per gic callback: do stuff assuming lock held
> >         common: release lock
> >
> > IOW the lock is only used from the common code?
> >
> Yes, lock is only used in common code and your pattern is correct.

Why is gic.lock not alright?

> I made it separate patch as this is not trivial change
> 
> > Ian.
> >