All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Gong" <gong.chen@linux.intel.com>
To: hpa@zytor.com, tony.luck@intel.com
Cc: tglx@linutronix.de, mingo@kernel.org,
	linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	"Chen, Gong" <gong.chen@linux.intel.com>
Subject: [PATCH 1/2] x86, CMCI: Fix a missed put_cpu_var
Date: Mon, 14 Apr 2014 04:39:36 -0400	[thread overview]
Message-ID: <1397464777-25451-1-git-send-email-gong.chen@linux.intel.com> (raw)
In-Reply-To: <tip-27f6c573e0f77f7d1cc907c1494c99a61e48b7d8@git.kernel.org>

This issue is introduced in commit 27f6c573e0. I forget to
execute put_cpu_var operation after get_cpu_var.

Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
---
 arch/x86/kernel/cpu/mcheck/mce.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index eeee23f..26eaf3b 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -620,6 +620,7 @@ void machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
 
 		v = &get_cpu_var(mce_polled_error);
 		set_bit(0, v);
+		put_cpu_var(mce_polled_error);
 		/*
 		 * Uncorrected or signalled events are handled by the exception
 		 * handler when it is enabled, so don't process those here.
-- 
1.9.0


  parent reply	other threads:[~2014-04-14  9:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-27f6c573e0f77f7d1cc907c1494c99a61e48b7d8@git.kernel.org>
2014-04-02  8:51 ` [tip:x86/urgent] x86, CMCI: Add proper detection of end of CMCI storms William Dauchy
2014-04-02  9:01   ` Borislav Petkov
2014-04-02  9:06     ` William Dauchy
2014-04-02 10:46     ` Ingo Molnar
2014-04-02 10:52       ` Borislav Petkov
2014-04-11 17:01 ` H. Peter Anvin
2014-04-14  8:39 ` Chen, Gong [this message]
2014-04-14  8:39   ` [PATCH 2/2] x86, MCE: Cleanup macro __get_cpu_var Chen, Gong
2014-04-14 16:19     ` H. Peter Anvin
2014-04-14 16:20     ` H. Peter Anvin
2014-04-14 16:23     ` H. Peter Anvin
2014-04-15  2:28       ` Chen, Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397464777-25451-1-git-send-email-gong.chen@linux.intel.com \
    --to=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.