From: Sasha Levin <sasha.levin@oracle.com>
To: vegard.nossum@oracle.com, penberg@kernel.org
Cc: jamie.iles@oracle.com, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org,
masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org,
linux-mm@vger.kernel.org, Sasha Levin <sasha.levin@oracle.com>
Subject: [PATCH 1/4] kmemcheck: add additional selfchecks
Date: Mon, 14 Apr 2014 13:44:07 -0400 [thread overview]
Message-ID: <1397497450-6440-1-git-send-email-sasha.levin@oracle.com> (raw)
kmemcheck has it's own tiny opcode decoder, and is not using the
kernel's decoder for historic reasons.
While the decoder works for more cases, it fails on quite a few
opcodes and returns incorrect values, which leads to either a
failure to detect an issue, or a false positive.
This patch adds a few of those opcodes: setne, btsl and callq,
thus causing selfcheck to fail during boot.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
arch/x86/mm/kmemcheck/selftest.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/x86/mm/kmemcheck/selftest.c b/arch/x86/mm/kmemcheck/selftest.c
index aef7140..c898d33 100644
--- a/arch/x86/mm/kmemcheck/selftest.c
+++ b/arch/x86/mm/kmemcheck/selftest.c
@@ -23,6 +23,12 @@ static const struct selftest_opcode selftest_opcodes[] = {
{1, "\x66\x0f\xbe\x51\xf8", "movswq <mem8>, <reg16>"},
{1, "\x0f\xbe\x51\xf8", "movswq <mem8>, <reg32>"},
+ /* SETNE */
+ {1, "\x0f\x95\xc0", "setne <reg8>"},
+
+ /* BTSL */
+ {4, "\x0f\xba\x6b\x10\x00", "btsl <imm8>, <mem32>"},
+
#ifdef CONFIG_X86_64
/* MOVZX / MOVZXD */
{1, "\x49\x0f\xb6\x51\xf8", "movzbq <mem8>, <reg64>"},
@@ -32,6 +38,9 @@ static const struct selftest_opcode selftest_opcodes[] = {
{1, "\x49\x0f\xbe\x51\xf8", "movsbq <mem8>, <reg64>"},
{2, "\x49\x0f\xbf\x51\xf8", "movsbq <mem16>, <reg64>"},
{4, "\x49\x63\x51\xf8", "movslq <mem32>, <reg64>"},
+
+ /* CALLQ */
+ {8, "\xe8\x00\x00\x00", "call <mem64>"},
#endif
};
--
1.7.10.4
next reply other threads:[~2014-04-14 17:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:44 Sasha Levin [this message]
2014-04-14 17:44 ` [PATCH 2/4] x86: Move instruction decoder data into header Sasha Levin
2014-04-15 1:41 ` Masami Hiramatsu
2014-04-15 2:28 ` Sasha Levin
2014-04-15 3:10 ` Masami Hiramatsu
2014-04-15 14:24 ` Sasha Levin
2014-04-16 3:06 ` Masami Hiramatsu
2014-04-14 17:44 ` [PATCH 3/4] x86/insn: Extract more information about instructions Sasha Levin
2014-04-15 3:12 ` Masami Hiramatsu
2014-04-15 4:36 ` Masami Hiramatsu
2014-04-15 15:10 ` Sasha Levin
2014-04-16 3:26 ` H. Peter Anvin
2014-04-16 3:47 ` Sasha Levin
2014-04-16 3:54 ` H. Peter Anvin
2014-04-16 4:03 ` Sasha Levin
2014-04-16 4:31 ` H. Peter Anvin
2014-04-16 5:30 ` Masami Hiramatsu
2014-04-17 15:20 ` Sasha Levin
2014-04-17 15:28 ` H. Peter Anvin
2014-04-17 17:31 ` Sasha Levin
2014-04-18 3:40 ` Masami Hiramatsu
2014-04-18 3:45 ` H. Peter Anvin
2014-04-18 15:47 ` Sasha Levin
2014-04-18 16:48 ` H. Peter Anvin
2014-04-16 5:44 ` Masami Hiramatsu
2014-04-17 15:33 ` Sasha Levin
2014-04-18 3:25 ` Masami Hiramatsu
2014-04-14 17:44 ` [PATCH 4/4] kmemcheck: Switch to using kernel disassembler Sasha Levin
2014-04-15 8:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397497450-6440-1-git-send-email-sasha.levin@oracle.com \
--to=sasha.levin@oracle.com \
--cc=hpa@zytor.com \
--cc=jamie.iles@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
--cc=vegard.nossum@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.