All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vyacheslav Dubeyko <slava@dubeyko.com>
To: Hin-Tak Leung <hintak.leung@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Anton Altaparmakov <aia21@cam.ac.uk>,
	Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH 4/4] hfsplus: fixes error propagation of hfsplus_asc2uni
Date: Tue, 15 Apr 2014 10:55:54 +0400	[thread overview]
Message-ID: <1397544954.2225.5.camel@slavad-CELSIUS-H720> (raw)
In-Reply-To: <1397535612-24058-4-git-send-email-HinTak.Leung@gmail.com>

Hi Hin-Tak,

On Tue, 2014-04-15 at 05:20 +0100, Hin-Tak Leung wrote:
> From: Hin-Tak Leung <htl10@users.sourceforge.net>
> 
> hfsplus_asc2uni() converts NLS strings to unicode on-disk representation.
> It can fail if the input is tool long to fit the destination
> (255 unicode characters for files and 127 for attributes).
> The error propagation for attributes (only one usage of hfsplus_asc2uni()
> in hfsplus_attr_cat_build_key() ) is part of an earlier patch.
> 
> In the catalog code, hfsplus_asc2uni() is used by two routines,
> hfsplus_cat_build_key() and hfsplus_fill_cat_thread().
> The prototypes of those two are extended, and all callers to these two
> routines now check and try to catch errors from them.
> 

As I remember, this work has been done by Sougata Santra
<sougata@tuxera.com>. And his patch [1], [2] in the next tree now.

Could you check that you've add something new?

Thanks,
Vyacheslav Dubeyko.

[1] https://lkml.org/lkml/2014/2/24/498
[2] https://lkml.org/lkml/2014/2/24/807



  reply	other threads:[~2014-04-15  6:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  4:20 [PATCH 1/4] hfsplus: fixes worst-case unicode to char conversion of file names and attributes Hin-Tak Leung
2014-04-15  4:20 ` [PATCH 2/4] hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes Hin-Tak Leung
2014-04-15  4:20 ` [PATCH 3/4] hfsplus: remove unused routine hfsplus_attr_build_key_uni Hin-Tak Leung
2014-04-15  4:20 ` [PATCH 4/4] hfsplus: fixes error propagation of hfsplus_asc2uni Hin-Tak Leung
2014-04-15  6:55   ` Vyacheslav Dubeyko [this message]
2014-04-15 15:59     ` Hin-Tak Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397544954.2225.5.camel@slavad-CELSIUS-H720 \
    --to=slava@dubeyko.com \
    --cc=aia21@cam.ac.uk \
    --cc=hch@infradead.org \
    --cc=hintak.leung@gmail.com \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.