All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Foley <pefoley2@pefoley.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Foley <pefoley2@pefoley.com>,
	tj@kernel.org, linux-ide@vger.kernel.org
Subject: [PATCH] ata: fix kconfig selection warning
Date: Tue, 15 Apr 2014 13:50:55 -0400	[thread overview]
Message-ID: <1397584255-15038-1-git-send-email-pefoley2@pefoley.com> (raw)

When building with COMPILE_TEST, AHCI_XGENE is enabled even though
PHY_XGENE (which it selects) requires OF to be enabled.
Fix this by adding a dependency on OF to AHCI_XGENE.

warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))

Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 20e03a7..071f399 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -134,7 +134,7 @@ config AHCI_SUNXI
 
 config AHCI_XGENE
 	tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
-	depends on ARM64 || COMPILE_TEST
+	depends on OF && (ARM64 || COMPILE_TEST)
 	select PHY_XGENE
 	help
 	 This option enables support for APM X-Gene SoC SATA host controller.
-- 
1.9.2


             reply	other threads:[~2014-04-15 17:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 17:50 Peter Foley [this message]
2014-04-15 18:17 ` [PATCH] ata: fix kconfig selection warning Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397584255-15038-1-git-send-email-pefoley2@pefoley.com \
    --to=pefoley2@pefoley.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.