From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 18 Apr 2014 17:23:21 -0500 Subject: [U-Boot] [PATCH 01/11] SPL: NAND: remove CONFIG_SYS_NAND_PAGE_SIZE In-Reply-To: References: <1396504871-1454-1-git-send-email-tharvey@gateworks.com> <1396504871-1454-2-git-send-email-tharvey@gateworks.com> <534BC8C4.1080707@denx.de> Message-ID: <1397859801.1694.137.camel@snotra.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2014-04-17 at 07:18 -0700, Tim Harvey wrote: > On Mon, Apr 14, 2014 at 4:38 AM, Stefano Babic wrote: > > On 03/04/2014 08:01, Tim Harvey wrote: > >> We only need to read in the size of struct image_header and thus don't > >> need to know the page size of the nand device. > >> > >> Signed-off-by: Tim Harvey > >> --- > >> common/spl/spl_nand.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c > >> index 9da0218..062461b 100644 > >> --- a/common/spl/spl_nand.c > >> +++ b/common/spl/spl_nand.c > >> @@ -76,7 +76,7 @@ void spl_nand_load_image(void) > >> #endif > >> /* Load u-boot */ > >> nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS, > >> - CONFIG_SYS_NAND_PAGE_SIZE, (void *)header); > >> + sizeof(*header), (void *)header); > >> spl_parse_image_header(header); > >> nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS, > >> spl_image.size, (void *)spl_image.load_addr); > >> > > > > Acked-by: Stefano Babic > > > > Best regards, > > Stefano Babic > > > > Scott, > > This should have been addressed to you in the first place as its NAND > and not IMX specific. It's been +1'd and ack'd, so if you agree with > it and commit it I'll remove it from my next patch series regarding > IMX6 SPL NAND support. I suppose it's not worse than what's already there, but I really don't like the way nand_spl_load_image takes a pointer and a size, but can write more bytes to the pointer than the size that was given (it rounds up to the block -- not page -- size). That said, Acked-by: Scott Wood ...and feel free to leave it in with the rest of the patchset. -Scott