From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix v7-M signal return
Date: Mon, 21 Apr 2014 20:07:44 +0200 [thread overview]
Message-ID: <1398103664-23078-1-git-send-email-rabin@rab.in> (raw)
According to the ARM ARM, the behaviour is UNDPREDICTABLE if the PC read
from the exception return stack is not half word aligned. See the
pseudo code for ExceptionReturn() and PopStack().
The signal handler's address has the bit 0 set, and setup_return()
directly writes this to regs->ARM_pc. Mask out bit 0 before the
exception return to get predictable behaviour.
Signed-off-by: Rabin Vincent <rabin@rab.in>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
index 1420725..ef72f4b 100644
--- a/arch/arm/kernel/entry-header.S
+++ b/arch/arm/kernel/entry-header.S
@@ -133,6 +133,7 @@
biceq r5, V7M_xPSR_FRAMEPTRALIGN
@ write basic exception frame
+ bic r4, r4, #1
stmdb r2!, {r1, r3-r5}
ldmia sp, {r1, r3-r5}
.if \ret_r0
--
1.9.1
next reply other threads:[~2014-04-21 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 18:07 Rabin Vincent [this message]
2014-04-28 8:27 ` [PATCH] ARM: fix v7-M signal return Uwe Kleine-König
2014-05-03 17:39 ` Rabin Vincent
2014-05-03 18:45 ` Uwe Kleine-König
2014-05-04 15:36 ` Rabin Vincent
2014-05-05 13:28 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398103664-23078-1-git-send-email-rabin@rab.in \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.