From: Rusty Russell <rusty@rustcorp.com.au>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Vincent Sanders <vince@simtec.co.uk>,
Ben Dooks <ben@simtec.co.uk>
Subject: [PATCH 2/9] drivers/video/fbdev/sm501fb.c: avoid world-writable sysfs files.
Date: Tue, 22 Apr 2014 13:03:25 +0930 [thread overview]
Message-ID: <1398137612-9714-3-git-send-email-rusty@rustcorp.com.au> (raw)
In-Reply-To: <1398137612-9714-1-git-send-email-rusty@rustcorp.com.au>
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.
Cc: Vincent Sanders <vince@simtec.co.uk>
Cc: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/video/fbdev/sm501fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 1501979099dc..c2c8eb668784 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1215,7 +1215,7 @@ static ssize_t sm501fb_crtsrc_store(struct device *dev,
}
/* Prepare the device_attr for registration with sysfs later */
-static DEVICE_ATTR(crt_src, 0666, sm501fb_crtsrc_show, sm501fb_crtsrc_store);
+static DEVICE_ATTR(crt_src, 0664, sm501fb_crtsrc_show, sm501fb_crtsrc_store);
/* sm501fb_show_regs
*
--
1.8.3.2
next prev parent reply other threads:[~2014-04-22 3:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 3:33 [PATCH 0/9] Avoid world-writable sysfs files Rusty Russell
2014-04-22 3:33 ` [PATCH 1/9] drivers/mtd/devices/docg3.c: avoid " Rusty Russell
2014-04-22 3:33 ` Rusty Russell [this message]
2014-04-22 3:33 ` [PATCH 3/9] drivers/hid/hid-lg4ff.c: " Rusty Russell
2014-04-22 16:30 ` simon
2014-04-23 5:34 ` Rusty Russell
2014-04-23 15:06 ` simon
2014-04-24 3:25 ` Rusty Russell
[not found] ` <gz6xrj.n4iwpm.2st9zt-qmf@smtp.devoid-pointer.net>
2014-04-24 7:14 ` Rusty Russell
2014-04-22 3:33 ` [PATCH 4/9] drivers/scsi/pm8001/pm8001_ctl.c: " Rusty Russell
2014-04-22 3:33 ` [PATCH 5/9] drivers/regulator/virtual: " Rusty Russell
2014-04-22 3:33 ` [PATCH 6/9] drivers/staging/speakup/: " Rusty Russell
2014-04-22 16:37 ` Greg Kroah-Hartman
2014-04-24 4:27 ` Rusty Russell
2014-04-24 19:29 ` Greg Kroah-Hartman
2014-04-22 3:33 ` [PATCH 7/9] drivers/hid/hid-picolcd_fb: " Rusty Russell
2014-05-02 19:43 ` Bruno Prémont
2014-05-05 1:57 ` Rusty Russell
2014-05-05 9:02 ` Jiri Kosina
2014-04-22 3:33 ` [PATCH 8/9] samples/kobject/: " Rusty Russell
2014-04-22 16:38 ` Greg Kroah-Hartman
2014-04-22 3:33 ` [PATCH 9/9] sysfs: disallow world-writable files Rusty Russell
2015-04-29 12:24 ` Gobinda Charan Maji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398137612-9714-3-git-send-email-rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ben@simtec.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=vince@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.