From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: [PATCH v4 02/18] xen/arm: IRQ: Use default irq callback from common code for no_irq_type Date: Tue, 22 Apr 2014 13:58:34 +0100 Message-ID: <1398171530-27391-3-git-send-email-julien.grall@linaro.org> References: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WcaHr-0001gE-LC for xen-devel@lists.xenproject.org; Tue, 22 Apr 2014 12:59:00 +0000 Received: by mail-ee0-f45.google.com with SMTP id d17so4550941eek.18 for ; Tue, 22 Apr 2014 05:58:58 -0700 (PDT) In-Reply-To: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Most of no_irq_type callback are already defined in common/irq.c. We don't need to recreate our own callbacks. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- Changes in v2: - Patch added --- xen/arch/arm/irq.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 3e326b0..5d1ed7f 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -27,23 +27,19 @@ #include -static void enable_none(struct irq_desc *irq) { } -static unsigned int startup_none(struct irq_desc *irq) { return 0; } -static void disable_none(struct irq_desc *irq) { } static void ack_none(struct irq_desc *irq) { printk("unexpected IRQ trap at irq %02x\n", irq->irq); } -#define shutdown_none disable_none -#define end_none enable_none +static void end_none(struct irq_desc *irq) { } hw_irq_controller no_irq_type = { .typename = "none", - .startup = startup_none, - .shutdown = shutdown_none, - .enable = enable_none, - .disable = disable_none, + .startup = irq_startup_none, + .shutdown = irq_shutdown_none, + .enable = irq_enable_none, + .disable = irq_disable_none, .ack = ack_none, .end = end_none }; -- 1.7.10.4