From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 12/16] xen/arm: split vgic driver into generic and vgic-v2 driver Date: Wed, 23 Apr 2014 16:12:13 +0100 Message-ID: <1398265933.18537.165.camel@kazak.uk.xensource.com> References: <1397560675-29861-1-git-send-email-vijay.kilari@gmail.com> <1397560675-29861-13-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397560675-29861-13-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, julien.grall@linaro.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2014-04-15 at 16:47 +0530, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Existing vGIC driver has both generic code and hw specific > code. Segregate vGIC low level driver into vgic-v2.c and > keep generic code in existing vgic.c file > > some static generic functions in vgic.c is made as non-static > so that these generic functions can be used in vGIC v2 driver. > > vGIC v2 driver registers required callbacks to generic vGIC > driver. This helps to plug in next version of vGIC drivers > like vGIC v3 Please can you clarify that the intention here is that all domains use the same version of vgic as the physical gic. Otherwise I'm going to ask why these callbacks aren't domain specific. > +struct vgic_ops { > + int (*vgic_vcpu_init)(struct vcpu *v); > + int (*vgic_domain_init)(struct domain *d); The vgic prefix here is unnecessary. > + int (*read_priority)(struct vcpu *v, int irq); get_irq_priority would be a better name I think. Ian.