From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754663AbaDXMwj (ORCPT ); Thu, 24 Apr 2014 08:52:39 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:62642 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370AbaDXMwe (ORCPT ); Thu, 24 Apr 2014 08:52:34 -0400 Message-ID: <1398343612.4295.66.camel@herbert.er.corscience.de> Subject: Re: [RFC 0/3] DRM driver for the ATMEL High end LCD controller From: Tim Niemeyer To: Boris BREZILLON Cc: Jean-Jacques Hiblot , Robert Nelson , nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, robdclark@gmail.com, plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org Date: Thu, 24 Apr 2014 14:46:52 +0200 In-Reply-To: <5359000C.50005@free-electrons.com> References: <1397814309-32160-1-git-send-email-jjhiblot@traphandler.com> <1398267396.4295.59.camel@herbert.er.corscience.de> <5359000C.50005@free-electrons.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:LOfn9PBOnVrB17usg6TQ67eftNTG3RXT9i1GQbm93Ff lNZfckSnbIcLguSGveJpkY2AXTERGW/fHrrwuAgbRRYxU/EeLy zOYYs9AyxxGjWb79+JxEp3XDLXJ6GHjmYw+4eOuaVvJvT8PI7D BQ7nJtWNmXMXsRIdNOAo1rCoNrrqSDiK+Ib3O9oCkAvl2iR2Uy DiH2sAN5fhsk2TqXJXDm8AHNu+4jkMzEjjSyn2g0KK8TGd/UxG fEvIA04mjpcLS80YmFABpagW4vpIZgsuzde4/lXV0JyxVjHVHB Y7EPtMHzwS1RbiljUAgubJSWeFDs1j7GL6t2Muh9kIsIa8aAdB DjZwOEAYBR0PUFGTQeZfPK4JJYY4dpydJtnYvuOmXdJgIk+sIo EP7KCRVDRKWs+uxRTbobwA7uzfvziAQ+0A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON: > Hi Tim, > > On 23/04/2014 17:36, Tim Niemeyer wrote: > > Hi Jean-Jacques, > > > > Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot: > >> Hi, > >> > >> this patch serie implements a simple DRM driver for the ATMEL High end LCD > >> controller found in the SAMA5 familly. It's based on the tilcdc driver. > >> It uses the cma_helper for memory and fbdev stuff. > >> Your comments are welcome ! > > I applied your and Robert's patches on a 3.15-rc2 kernel and tried the > > framebuffer device on the sama5d31-ek. Seems to work. > > > >> Supported features: > >> * the base layer (the main framebuffer) > > Tested to show a little tux png, but it's appearing only after > > 'echo 0 > /sys/devices/ahb.1/apb.2/f0030000.hlcdc/graphics/fb0/rotate' > > is there missing some initializing? > > Could you try to apply this http://code.bulix.org/f01kvh-86117 ? I can't see any difference with that. I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the display stays with a small atmel logo and u-Boot version information. If i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel start and fbv just works as expected. Best Regards, Tim > Best Regards, > > Boris > > > > >> * a simple panel > >> * a backlight driver > > Tested to set brightness to 0, 20 and 255. Works. > > > > Thanks for your work. > > > > Best Regards > > Tim > > > >> * structure to 'easily' add other connectors (it comes from the tilcdc) > >> > >> On the todo list: > >> * support overlays as drm_planes > >> * support for the hardware cursor > >> * support for the SiI9022 HDMI connector (present on sama5d36ek) > >> > >> > >> Jean-Jacques Hiblot (3): > >> atmel: drm: added drm driver for the atmel hlcd controller > >> atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5 > >> atmel: dt: Add supports for the lcdc support on the sama5d36ek > >> > >> arch/arm/boot/dts/sama5d36ek.dts | 27 +- > >> arch/arm/boot/dts/sama5d3_lcd.dtsi | 11 + > >> drivers/gpu/drm/Kconfig | 2 + > >> drivers/gpu/drm/Makefile | 1 + > >> drivers/gpu/drm/atmel_hlcdc/Kconfig | 13 + > >> drivers/gpu/drm/atmel_hlcdc/Makefile | 12 + > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h | 771 +++++++++++++++++++++ > >> .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c | 92 +++ > >> .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h | 25 + > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 +++++++++++++++++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c | 586 ++++++++++++++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h | 124 ++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h | 190 +++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c | 459 ++++++++++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h | 28 + > >> 15 files changed, 3042 insertions(+), 1 deletion(-) > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h > >> > >> -- > >> 1.9.1 > >> > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: tim.niemeyer@corscience.de (Tim Niemeyer) Date: Thu, 24 Apr 2014 14:46:52 +0200 Subject: [RFC 0/3] DRM driver for the ATMEL High end LCD controller In-Reply-To: <5359000C.50005@free-electrons.com> References: <1397814309-32160-1-git-send-email-jjhiblot@traphandler.com> <1398267396.4295.59.camel@herbert.er.corscience.de> <5359000C.50005@free-electrons.com> Message-ID: <1398343612.4295.66.camel@herbert.er.corscience.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON: > Hi Tim, > > On 23/04/2014 17:36, Tim Niemeyer wrote: > > Hi Jean-Jacques, > > > > Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot: > >> Hi, > >> > >> this patch serie implements a simple DRM driver for the ATMEL High end LCD > >> controller found in the SAMA5 familly. It's based on the tilcdc driver. > >> It uses the cma_helper for memory and fbdev stuff. > >> Your comments are welcome ! > > I applied your and Robert's patches on a 3.15-rc2 kernel and tried the > > framebuffer device on the sama5d31-ek. Seems to work. > > > >> Supported features: > >> * the base layer (the main framebuffer) > > Tested to show a little tux png, but it's appearing only after > > 'echo 0 > /sys/devices/ahb.1/apb.2/f0030000.hlcdc/graphics/fb0/rotate' > > is there missing some initializing? > > Could you try to apply this http://code.bulix.org/f01kvh-86117 ? I can't see any difference with that. I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the display stays with a small atmel logo and u-Boot version information. If i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel start and fbv just works as expected. Best Regards, Tim > Best Regards, > > Boris > > > > >> * a simple panel > >> * a backlight driver > > Tested to set brightness to 0, 20 and 255. Works. > > > > Thanks for your work. > > > > Best Regards > > Tim > > > >> * structure to 'easily' add other connectors (it comes from the tilcdc) > >> > >> On the todo list: > >> * support overlays as drm_planes > >> * support for the hardware cursor > >> * support for the SiI9022 HDMI connector (present on sama5d36ek) > >> > >> > >> Jean-Jacques Hiblot (3): > >> atmel: drm: added drm driver for the atmel hlcd controller > >> atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5 > >> atmel: dt: Add supports for the lcdc support on the sama5d36ek > >> > >> arch/arm/boot/dts/sama5d36ek.dts | 27 +- > >> arch/arm/boot/dts/sama5d3_lcd.dtsi | 11 + > >> drivers/gpu/drm/Kconfig | 2 + > >> drivers/gpu/drm/Makefile | 1 + > >> drivers/gpu/drm/atmel_hlcdc/Kconfig | 13 + > >> drivers/gpu/drm/atmel_hlcdc/Makefile | 12 + > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h | 771 +++++++++++++++++++++ > >> .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c | 92 +++ > >> .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h | 25 + > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 +++++++++++++++++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c | 586 ++++++++++++++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h | 124 ++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h | 190 +++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c | 459 ++++++++++++ > >> drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h | 28 + > >> 15 files changed, 3042 insertions(+), 1 deletion(-) > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c > >> create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h > >> > >> -- > >> 1.9.1 > >> > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel at lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > >