From: James Bottomley <jbottomley@parallels.com>
To: "ching2048@areca.com.tw" <ching2048@areca.com.tw>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"thenzl@redhat.com" <thenzl@redhat.com>
Subject: Re: [PATCH v1.0 1/11] arcmsr: Revise interrupt service routine relate function
Date: Wed, 30 Apr 2014 16:56:04 +0000 [thread overview]
Message-ID: <1398876964.2182.13.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1398850855.1769.11.camel@localhost>
On Wed, 2014-04-30 at 17:40 +0800, ching wrote:
> From: Ching<ching2048@areca.com.tw>
>
> Rewrite interrupt service routine relate function to fix command
> timeout on controller very heavy loading.
OK, so I think you've confused us a bit. This looks to be an update of
your previous v1.4 patch set, yet it's now called v1.0?
Could you please include a cover letter as patch 0/x like you see
everyone else doing on the list? In this cover letter can you tell us
what the disposition of the previous feedback is and what other changes
have you done? You didn't reply to any of the comments, have have you
fixed them? It's very dispiriting to review 11 patches, give feedback
and not hear anything ... and then have to review an even longer set of
patches just to see if anything was done about your previous comments.
The less interactive you are with reviews, the less chance there is that
people will review updates ... without external reviewers, you go on a
very long backlog of things I have to review before the patches get in.
James
next prev parent reply other threads:[~2014-04-30 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 9:40 [PATCH v1.0 1/11] arcmsr: Revise interrupt service routine relate function ching
2014-04-30 16:56 ` James Bottomley [this message]
2014-05-02 9:51 ` 黃清隆
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398876964.2182.13.camel@dabdike.int.hansenpartnership.com \
--to=jbottomley@parallels.com \
--cc=ching2048@areca.com.tw \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.