From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v3 24/25] drm/i915: propagate the error code from runtime PM callbacks Date: Wed, 30 Apr 2014 21:53:08 +0300 Message-ID: <1398883988.6339.8.camel@ideak-mobl> References: <1397496286-29649-25-git-send-email-imre.deak@intel.com> <1397569185-3353-1-git-send-email-imre.deak@intel.com> <20140430180530.GP18465@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 242A96E6D9 for ; Wed, 30 Apr 2014 11:53:15 -0700 (PDT) In-Reply-To: <20140430180530.GP18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE0LTA0LTMwIGF0IDIxOjA1ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gVHVlLCBBcHIgMTUsIDIwMTQgYXQgMDQ6Mzk6NDVQTSArMDMwMCwgSW1yZSBEZWFrIHdy b3RlOgo+ID4gQXRtLCBub25lIG9mIHRoZSBSUE0gY2FsbGJhY2tzIGNhbiBmYWlsLCBidXQgdGhl IG5leHQgcGF0Y2ggYWRkaW5nCj4gPiBSUE0gc3VwcG9ydCBmb3IgVkxWIGNoYW5nZXMgdGhpcywg c28gcHJlcGFyZSBmb3IgaXQuCj4gPiAKPiA+IEluIGNhc2Ugb25lIG9mIHRoZXNlIGNhbGxiYWNr cyByZXR1cm4gZXJyb3IgUlBNIHdpbGwgZ2V0IHBlcm1hbmVudGx5Cj4gPiBkaXNhYmxlZCB1bnRp bCB0aGUgZXJyb3IgaXMgZXhwbGljaXRseSBjbGVhcmVkLiBJbiB0aGUgZnV0dXJlIHdlIGNvdWxk Cj4gPiBhZGQgc3VwcG9ydCBmb3IgcmUtZW5hYmxpbmcgaXQsIGZvciBleGFtcGxlIGFmdGVyIHJl c2V0dGluZyB0aGUgSFcsIGJ1dAo+ID4gZm9yIG5vdyAtIGhvcGVmdWxseSAtIHdlIGNhbiBsaXZl IHdpdGggdGhlIHNpbXBsZXIgc29sdXRpb24uCj4gPiAKPiA+IHYyOgo+ID4gLSBwcm9wYWdhdGUg dGhlIGVycm9yIGZyb20gdGhlIHJlc3VtZSBjYWxsYmFja3MgdG9vIChQYXVsbykKPiA+IHYzOgo+ ID4gLSBmaXggcmViYXNlIGZhaWwgdHlwbyBhcm91bmQgSVNfR0VONigpIGNoZWNrIGluIGludGVs X3J1bnRpbWVfc3VzcGVuZCgpCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1y ZS5kZWFrQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmMgfCA1NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ID4g IDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiA+IAo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiBpbmRleCA4NDVlMWUxLi5hZWI3ZGVjIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gQEAgLTg4OCwyMSArODg4LDI3IEBAIHN0 YXRpYyBpbnQgaTkxNV9wbV9wb3dlcm9mZihzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiAgCXJldHVy biBpOTE1X2RybV9mcmVlemUoZHJtX2Rldik7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB2b2lk IGhzd19ydW50aW1lX3N1c3BlbmQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ID4gK3N0YXRpYyBpbnQgaHN3X3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gPiAgewo+ID4gIAloc3dfZW5hYmxlX3BjOChkZXZfcHJpdik7Cj4gPiAr Cj4gPiArCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+IC1zdGF0aWMgdm9pZCBzbmJfcnVudGlt ZV9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gK3N0YXRpYyBp bnQgc25iX3J1bnRpbWVfcmVzdW1lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiA+ICB7Cj4gPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkZXZfcHJpdi0+ZGV2Owo+ID4g IAo+ID4gIAlpbnRlbF9pbml0X3BjaF9yZWZjbGsoZGV2KTsKPiA+ICsKPiA+ICsJcmV0dXJuIDA7 Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB2b2lkIGhzd19ydW50aW1lX3Jlc3VtZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiArc3RhdGljIGludCBoc3dfcnVudGltZV9y ZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJaHN3 X2Rpc2FibGVfcGM4KGRldl9wcml2KTsKPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiAgfQo+ID4g IAo+ID4gIGludCB2bHZfZm9yY2VfZ2Z4X2Nsb2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwgYm9vbCBmb3JjZV9vbikKPiA+IEBAIC05NDcsNiArOTUzLDcgQEAgc3RhdGljIGlu dCBpbnRlbF9ydW50aW1lX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2aWNlKQo+ID4gIAlzdHJ1 Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2aWNlKTsKPiA+ICAJc3RydWN0IGRybV9k ZXZpY2UgKmRldiA9IHBjaV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiA+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ICsJaW50IHJldDsKPiA+ ICAKPiA+ICAJaWYgKFdBUk5fT05fT05DRSghKGRldl9wcml2LT5ycHMuZW5hYmxlZCAmJiBpbnRl bF9lbmFibGVfcmM2KGRldikpKSkKPiA+ICAJCXJldHVybiAtRU5PREVWOwo+ID4gQEAgLTk1OSwx MiArOTY2LDIxIEBAIHN0YXRpYyBpbnQgaW50ZWxfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZp Y2UgKmRldmljZSkKPiA+ICAJaW50ZWxfcnVudGltZV9wbV9kaXNhYmxlX2ludGVycnVwdHMoZGV2 KTsKPiA+ICAJY2FuY2VsX3dvcmtfc3luYygmZGV2X3ByaXYtPnJwcy53b3JrKTsKPiA+ICAKPiA+ IC0JaWYgKElTX0dFTjYoZGV2KSkKPiA+IC0JCTsKPiA+IC0JZWxzZSBpZiAoSVNfSEFTV0VMTChk ZXYpIHx8IElTX0JST0FEV0VMTChkZXYpKQo+ID4gLQkJaHN3X3J1bnRpbWVfc3VzcGVuZChkZXZf cHJpdik7Cj4gPiAtCWVsc2UKPiA+ICsJaWYgKElTX0dFTjYoZGV2KSkgewo+ID4gKwkJcmV0ID0g MDsKPiA+ICsJfSBlbHNlIGlmIChJU19IQVNXRUxMKGRldikgfHwgSVNfQlJPQURXRUxMKGRldikp IHsKPiA+ICsJCXJldCA9IGhzd19ydW50aW1lX3N1c3BlbmQoZGV2X3ByaXYpOwo+ID4gKwl9IGVs c2Ugewo+ID4gKwkJcmV0ID0gLUVOT0RFVjsKPiA+ICAJCVdBUk5fT04oMSk7Cj4gPiArCX0KPiA+ ICsKPiA+ICsJaWYgKHJldCkgewo+ID4gKwkJRFJNX0VSUk9SKCJSdW50aW1lIHN1c3BlbmQgZmFp bGVkLCBkaXNhYmxpbmcgaXQgKCVkKVxuIiwgcmV0KTsKPiA+ICsJCWludGVsX3J1bnRpbWVfcG1f cmVzdG9yZV9pbnRlcnJ1cHRzKGRldik7Cj4gPiArCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwl9 Cj4gPiAgCj4gPiAgCWk5MTVfZ2VtX3JlbGVhc2VfYWxsX21tYXBzKGRldl9wcml2KTsKPiAKPiBO b3Qgc3RyaWN0bHkgcmVsYXRlZCB0byB0aGlzIHBhdGNoLCBidXQgc2hvdWxkbid0IHdlIG51a2Ug dGhlIG1tYXBzIGJlZm9yZQo+IGNhbGxpbmcgdGhlIHBsYXRmb3JtIHNwZWNpZmljIHJ1bnRpbWUg c3VzcGVuZCBmdW5jdGlvbj8KCldlIHRha2UgYW4gUlBNIHJlZiBvbiB0aGUgZmF1bHQgcGF0aCwg c28gYXQgbGVhc3QgdGhpcyBjb3VsZG4ndCByYWNlCndpdGggdXNlciBzcGFjZSBlaXRoZXIgd2F5 LiBCdXQgaWYgeW91IG1lYW50IHRoYXQgdGhlIHBsYXRmb3JtIGhvb2tzCmNvdWxkIHNhdmUvcmVz dG9yZSBzb21lIHN0YWxlIHN0YXRlIGJlY2F1c2Ugb2YgdGhpcyBvcmRlcmluZywgdGhlbiBJCmFn cmVlIGl0J2QgYmUgc2FmZXIgdG8gbW92ZSBpdCBiZWZvcmUgY2FsbGluZyB0aGUgcGxhdGZvcm0g aG9vay4gQnV0IEkKZG9uJ3Qgc2VlIHdoYXQgdGhpcyBzdGF0ZSB3b3VsZCBiZS4KCi0tSW1yZQoK PiBUaGlzIHBhdGNoIGl0c2VsZiBsb29rcyBvayB0byBtZToKPiBSZXZpZXdlZC1ieTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiA+ICAKPiA+IEBA IC05ODksNiArMTAwNSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfcnVudGltZV9yZXN1bWUoc3RydWN0 IGRldmljZSAqZGV2aWNlKQo+ID4gIAlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYo ZGV2aWNlKTsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHBjaV9nZXRfZHJ2ZGF0YShw ZGV2KTsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZf cHJpdmF0ZTsKPiA+ICsJaW50IHJldDsKPiA+ICAKPiA+ICAJV0FSTl9PTighSEFTX1JVTlRJTUVf UE0oZGV2KSk7Cj4gPiAgCj4gPiBAQCAtOTk3LDIxICsxMDE0LDMxIEBAIHN0YXRpYyBpbnQgaW50 ZWxfcnVudGltZV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2aWNlKQo+ID4gIAlpbnRlbF9vcHJl Z2lvbl9ub3RpZnlfYWRhcHRlcihkZXYsIFBDSV9EMCk7Cj4gPiAgCWRldl9wcml2LT5wbS5zdXNw ZW5kZWQgPSBmYWxzZTsKPiA+ICAKPiA+IC0JaWYgKElTX0dFTjYoZGV2KSkKPiA+IC0JCXNuYl9y dW50aW1lX3Jlc3VtZShkZXZfcHJpdik7Cj4gPiAtCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2KSB8 fCBJU19CUk9BRFdFTEwoZGV2KSkKPiA+IC0JCWhzd19ydW50aW1lX3Jlc3VtZShkZXZfcHJpdik7 Cj4gPiAtCWVsc2UKPiA+ICsJaWYgKElTX0dFTjYoZGV2KSkgewo+ID4gKwkJcmV0ID0gc25iX3J1 bnRpbWVfcmVzdW1lKGRldl9wcml2KTsKPiA+ICsJfSBlbHNlIGlmIChJU19IQVNXRUxMKGRldikg fHwgSVNfQlJPQURXRUxMKGRldikpIHsKPiA+ICsJCXJldCA9IGhzd19ydW50aW1lX3Jlc3VtZShk ZXZfcHJpdik7Cj4gPiArCX0gZWxzZSB7Cj4gPiAgCQlXQVJOX09OKDEpOwo+ID4gKwkJcmV0ID0g LUVOT0RFVjsKPiA+ICsJfQo+ID4gIAo+ID4gKwkvKgo+ID4gKwkgKiBObyBwb2ludCBvZiByb2xs aW5nIGJhY2sgdGhpbmdzIGluIGNhc2Ugb2YgYW4gZXJyb3IsIGFzIHRoZSBiZXN0Cj4gPiArCSAq IHdlIGNhbiBkbyBpcyB0byBob3BlIHRoYXQgdGhpbmdzIHdpbGwgc3RpbGwgd29yayAoYW5kIGRp c2FibGUgUlBNKS4KPiA+ICsJICovCj4gPiAgCWk5MTVfZ2VtX2luaXRfc3dpenpsaW5nKGRldik7 Cj4gPiAgCWdlbjZfdXBkYXRlX3JpbmdfZnJlcShkZXYpOwo+ID4gIAlpbnRlbF9yZXNldF9ndF9w b3dlcnNhdmUoZGV2KTsKPiA+ICAKPiA+ICAJaW50ZWxfcnVudGltZV9wbV9yZXN0b3JlX2ludGVy cnVwdHMoZGV2KTsKPiA+ICAKPiA+IC0JRFJNX0RFQlVHX0tNUygiRGV2aWNlIHJlc3VtZWRcbiIp Owo+ID4gLQlyZXR1cm4gMDsKPiA+ICsJaWYgKHJldCkKPiA+ICsJCURSTV9FUlJPUigiUnVudGlt ZSByZXN1bWUgZmFpbGVkLCBkaXNhYmxpbmcgaXQgKCVkKVxuIiwgcmV0KTsKPiA+ICsJZWxzZQo+ ID4gKwkJRFJNX0RFQlVHX0tNUygiRGV2aWNlIHJlc3VtZWRcbiIpOwo+ID4gKwo+ID4gKwlyZXR1 cm4gcmV0Owo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRldl9wbV9vcHMg aTkxNV9wbV9vcHMgPSB7Cj4gPiAtLSAKPiA+IDEuOC40Cj4gPiAKPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK