From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 1/8] tools: libxl: use uint64_t not unsigned long long for addresses Date: Fri, 2 May 2014 11:03:04 +0100 Message-ID: <1399024984.32736.10.camel@kazak.uk.xensource.com> References: <1398424945.18537.424.camel@kazak.uk.xensource.com> <1398424967-9306-1-git-send-email-ian.campbell@citrix.com> <21345.4843.327925.328440@mariner.uk.xensource.com> <1398872986.29888.12.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398872986.29888.12.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org, julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2014-04-30 at 16:49 +0100, Ian Campbell wrote: > On Wed, 2014-04-30 at 16:12 +0100, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH v2 1/8] tools: libxl: use uint64_t not unsigned long long for addresses"): > > > Signed-off-by: Ian Campbell > > > > If we are going to be doing this, why not introduce a type alias or > > two ? > > Good point. I'll do that. Actually, when I came to look at this I realised that because these numbers are being fed into device tree it is much simpler if they are of a fixed size rather than semantic type because you need to declare upfront the number of 32-bit cells each address and size value in the tree takes and it's much simpler to just declare up from "everything is 2 cells" and then use uint64_t throughout. Ian.