From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v3 24/25] drm/i915: propagate the error code from runtime PM callbacks Date: Mon, 05 May 2014 16:18:49 +0300 Message-ID: <1399295929.7584.5.camel@ideak-mobl> References: <1397496286-29649-25-git-send-email-imre.deak@intel.com> <1397569185-3353-1-git-send-email-imre.deak@intel.com> <20140430180530.GP18465@intel.com> <1398883988.6339.8.camel@ideak-mobl> <20140505124448.GY18465@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id EB5C36E17D for ; Mon, 5 May 2014 06:18:51 -0700 (PDT) In-Reply-To: <20140505124448.GY18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE0LTA1LTA1IGF0IDE1OjQ0ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gV2VkLCBBcHIgMzAsIDIwMTQgYXQgMDk6NTM6MDhQTSArMDMwMCwgSW1yZSBEZWFrIHdy b3RlOgo+ID4gT24gV2VkLCAyMDE0LTA0LTMwIGF0IDIxOjA1ICswMzAwLCBWaWxsZSBTeXJqw6Rs w6Qgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgQXByIDE1LCAyMDE0IGF0IDA0OjM5OjQ1UE0gKzAzMDAs IEltcmUgRGVhayB3cm90ZToKPiA+ID4gPiBBdG0sIG5vbmUgb2YgdGhlIFJQTSBjYWxsYmFja3Mg Y2FuIGZhaWwsIGJ1dCB0aGUgbmV4dCBwYXRjaCBhZGRpbmcKPiA+ID4gPiBSUE0gc3VwcG9ydCBm b3IgVkxWIGNoYW5nZXMgdGhpcywgc28gcHJlcGFyZSBmb3IgaXQuCj4gPiA+ID4gCj4gPiA+ID4g SW4gY2FzZSBvbmUgb2YgdGhlc2UgY2FsbGJhY2tzIHJldHVybiBlcnJvciBSUE0gd2lsbCBnZXQg cGVybWFuZW50bHkKPiA+ID4gPiBkaXNhYmxlZCB1bnRpbCB0aGUgZXJyb3IgaXMgZXhwbGljaXRs eSBjbGVhcmVkLiBJbiB0aGUgZnV0dXJlIHdlIGNvdWxkCj4gPiA+ID4gYWRkIHN1cHBvcnQgZm9y IHJlLWVuYWJsaW5nIGl0LCBmb3IgZXhhbXBsZSBhZnRlciByZXNldHRpbmcgdGhlIEhXLCBidXQK PiA+ID4gPiBmb3Igbm93IC0gaG9wZWZ1bGx5IC0gd2UgY2FuIGxpdmUgd2l0aCB0aGUgc2ltcGxl ciBzb2x1dGlvbi4KPiA+ID4gPiAKPiA+ID4gPiB2MjoKPiA+ID4gPiAtIHByb3BhZ2F0ZSB0aGUg ZXJyb3IgZnJvbSB0aGUgcmVzdW1lIGNhbGxiYWNrcyB0b28gKFBhdWxvKQo+ID4gPiA+IHYzOgo+ ID4gPiA+IC0gZml4IHJlYmFzZSBmYWlsIHR5cG8gYXJvdW5kIElTX0dFTjYoKSBjaGVjayBpbiBp bnRlbF9ydW50aW1lX3N1c3BlbmQoKQo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IElt cmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyB8IDU3ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCsp LCAxNSBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMK PiA+ID4gPiBpbmRleCA4NDVlMWUxLi5hZWI3ZGVjIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5jCj4gPiA+ID4gQEAgLTg4OCwyMSArODg4LDI3IEBAIHN0YXRpYyBpbnQg aTkxNV9wbV9wb3dlcm9mZihzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiA+ID4gIAlyZXR1cm4gaTkx NV9kcm1fZnJlZXplKGRybV9kZXYpOwo+ID4gPiA+ICB9Cj4gPiA+ID4gIAo+ID4gPiA+IC1zdGF0 aWMgdm9pZCBoc3dfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiA+ID4gPiArc3RhdGljIGludCBoc3dfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4gPiAgewo+ID4gPiA+ICAJaHN3X2VuYWJsZV9w YzgoZGV2X3ByaXYpOwo+ID4gPiA+ICsKPiA+ID4gPiArCXJldHVybiAwOwo+ID4gPiA+ICB9Cj4g PiA+ID4gIAo+ID4gPiA+IC1zdGF0aWMgdm9pZCBzbmJfcnVudGltZV9yZXN1bWUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ICtzdGF0aWMgaW50IHNuYl9ydW50aW1l X3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4gIHsKPiA+ ID4gPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkZXZfcHJpdi0+ZGV2Owo+ID4gPiA+ICAK PiA+ID4gPiAgCWludGVsX2luaXRfcGNoX3JlZmNsayhkZXYpOwo+ID4gPiA+ICsKPiA+ID4gPiAr CXJldHVybiAwOwo+ID4gPiA+ICB9Cj4gPiA+ID4gIAo+ID4gPiA+IC1zdGF0aWMgdm9pZCBoc3df cnVudGltZV9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ ICtzdGF0aWMgaW50IGhzd19ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4gPiA+ID4gIHsKPiA+ID4gPiAgCWhzd19kaXNhYmxlX3BjOChkZXZfcHJpdik7 Cj4gPiA+ID4gKwo+ID4gPiA+ICsJcmV0dXJuIDA7Cj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ ID4gIGludCB2bHZfZm9yY2VfZ2Z4X2Nsb2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwgYm9vbCBmb3JjZV9vbikKPiA+ID4gPiBAQCAtOTQ3LDYgKzk1Myw3IEBAIHN0YXRpYyBp bnQgaW50ZWxfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldmljZSkKPiA+ID4gPiAg CXN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXZpY2UpOwo+ID4gPiA+ICAJc3Ry dWN0IGRybV9kZXZpY2UgKmRldiA9IHBjaV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiA+ID4gPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiA+ ID4gKwlpbnQgcmV0Owo+ID4gPiA+ICAKPiA+ID4gPiAgCWlmIChXQVJOX09OX09OQ0UoIShkZXZf cHJpdi0+cnBzLmVuYWJsZWQgJiYgaW50ZWxfZW5hYmxlX3JjNihkZXYpKSkpCj4gPiA+ID4gIAkJ cmV0dXJuIC1FTk9ERVY7Cj4gPiA+ID4gQEAgLTk1OSwxMiArOTY2LDIxIEBAIHN0YXRpYyBpbnQg aW50ZWxfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldmljZSkKPiA+ID4gPiAgCWlu dGVsX3J1bnRpbWVfcG1fZGlzYWJsZV9pbnRlcnJ1cHRzKGRldik7Cj4gPiA+ID4gIAljYW5jZWxf d29ya19zeW5jKCZkZXZfcHJpdi0+cnBzLndvcmspOwo+ID4gPiA+ICAKPiA+ID4gPiAtCWlmIChJ U19HRU42KGRldikpCj4gPiA+ID4gLQkJOwo+ID4gPiA+IC0JZWxzZSBpZiAoSVNfSEFTV0VMTChk ZXYpIHx8IElTX0JST0FEV0VMTChkZXYpKQo+ID4gPiA+IC0JCWhzd19ydW50aW1lX3N1c3BlbmQo ZGV2X3ByaXYpOwo+ID4gPiA+IC0JZWxzZQo+ID4gPiA+ICsJaWYgKElTX0dFTjYoZGV2KSkgewo+ ID4gPiA+ICsJCXJldCA9IDA7Cj4gPiA+ID4gKwl9IGVsc2UgaWYgKElTX0hBU1dFTEwoZGV2KSB8 fCBJU19CUk9BRFdFTEwoZGV2KSkgewo+ID4gPiA+ICsJCXJldCA9IGhzd19ydW50aW1lX3N1c3Bl bmQoZGV2X3ByaXYpOwo+ID4gPiA+ICsJfSBlbHNlIHsKPiA+ID4gPiArCQlyZXQgPSAtRU5PREVW Owo+ID4gPiA+ICAJCVdBUk5fT04oMSk7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwo+ID4gPiA+ICsJ aWYgKHJldCkgewo+ID4gPiA+ICsJCURSTV9FUlJPUigiUnVudGltZSBzdXNwZW5kIGZhaWxlZCwg ZGlzYWJsaW5nIGl0ICglZClcbiIsIHJldCk7Cj4gPiA+ID4gKwkJaW50ZWxfcnVudGltZV9wbV9y ZXN0b3JlX2ludGVycnVwdHMoZGV2KTsKPiA+ID4gPiArCj4gPiA+ID4gKwkJcmV0dXJuIHJldDsK PiA+ID4gPiArCX0KPiA+ID4gPiAgCj4gPiA+ID4gIAlpOTE1X2dlbV9yZWxlYXNlX2FsbF9tbWFw cyhkZXZfcHJpdik7Cj4gPiA+IAo+ID4gPiBOb3Qgc3RyaWN0bHkgcmVsYXRlZCB0byB0aGlzIHBh dGNoLCBidXQgc2hvdWxkbid0IHdlIG51a2UgdGhlIG1tYXBzIGJlZm9yZQo+ID4gPiBjYWxsaW5n IHRoZSBwbGF0Zm9ybSBzcGVjaWZpYyBydW50aW1lIHN1c3BlbmQgZnVuY3Rpb24/Cj4gPiAKPiA+ IFdlIHRha2UgYW4gUlBNIHJlZiBvbiB0aGUgZmF1bHQgcGF0aCwgc28gYXQgbGVhc3QgdGhpcyBj b3VsZG4ndCByYWNlCj4gPiB3aXRoIHVzZXIgc3BhY2UgZWl0aGVyIHdheS4gQnV0IGlmIHlvdSBt ZWFudCB0aGF0IHRoZSBwbGF0Zm9ybSBob29rcwo+ID4gY291bGQgc2F2ZS9yZXN0b3JlIHNvbWUg c3RhbGUgc3RhdGUgYmVjYXVzZSBvZiB0aGlzIG9yZGVyaW5nLCB0aGVuIEkKPiA+IGFncmVlIGl0 J2QgYmUgc2FmZXIgdG8gbW92ZSBpdCBiZWZvcmUgY2FsbGluZyB0aGUgcGxhdGZvcm0gaG9vay4g QnV0IEkKPiA+IGRvbid0IHNlZSB3aGF0IHRoaXMgc3RhdGUgd291bGQgYmUuCj4gCj4gTXkgbWFp biB3b3JyeSBpcyB0aGF0IHNvbWV0aGluZyBtYXkgZ2V0IHR1cm5lZCBvZmYgaW4gdGhlIHBsYXRm b3JtCj4gc3BlY2lmaWMgY29kZSB3aGljaCBpcyByZXF1aXJlZCBieSB0aGUgaGFyZHdhcmUgdG8g c2VydmljZSBHVFQKPiBhY2Nlc3Nlcy4gQSBjb25jdXJyZWN0IEdUVCBhY2Nlc3MgbWF5IHRoZW4g aGFwcGVuIGFmdGVyIHRoZSBwbGF0Zm9ybQo+IHNwZWZpYyBjb2RlIGhhcyB0dXJuZWQgb2ZmIHRo ZSBoYXJkd2FyZSBidXQgYmVmb3JlIHRoZSBtbWFwcyBoYXZlIGJlZW4KPiByZWxlYXNlZCBhbmQg aGVuY2UgdGhlcmUncyBubyBmYXVsdCB3aGVuIHRoZSBhY2Nlc3MgaGFwcGVucy4KClJpZ2h0LCBm b3IgZXhpc3RpbmcgbWFwcyB0aGlzIG1heSBiZSBhIHByb2JsZW0uIEknbGwgZm9sbG93LXVwIHdp dGggYQpwYXRjaCBtb3ZpbmcgaTkxNV9nZW1fcmVsZWFzZV9hbGxfbW1hcHMoKSBlYXJsaWVyLgog Cj4gPiAtLUltcmUKPiA+IAo+ID4gPiBUaGlzIHBhdGNoIGl0c2VsZiBsb29rcyBvayB0byBtZToK PiA+ID4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gPiA+IAo+ID4gPiA+ICAKPiA+ID4gPiBAQCAtOTg5LDYgKzEwMDUsNyBAQCBz dGF0aWMgaW50IGludGVsX3J1bnRpbWVfcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldmljZSkKPiA+ ID4gPiAgCXN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXZpY2UpOwo+ID4gPiA+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHBjaV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiA+ID4g PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7 Cj4gPiA+ID4gKwlpbnQgcmV0Owo+ID4gPiA+ICAKPiA+ID4gPiAgCVdBUk5fT04oIUhBU19SVU5U SU1FX1BNKGRldikpOwo+ID4gPiA+ICAKPiA+ID4gPiBAQCAtOTk3LDIxICsxMDE0LDMxIEBAIHN0 YXRpYyBpbnQgaW50ZWxfcnVudGltZV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2aWNlKQo+ID4g PiA+ICAJaW50ZWxfb3ByZWdpb25fbm90aWZ5X2FkYXB0ZXIoZGV2LCBQQ0lfRDApOwo+ID4gPiA+ ICAJZGV2X3ByaXYtPnBtLnN1c3BlbmRlZCA9IGZhbHNlOwo+ID4gPiA+ICAKPiA+ID4gPiAtCWlm IChJU19HRU42KGRldikpCj4gPiA+ID4gLQkJc25iX3J1bnRpbWVfcmVzdW1lKGRldl9wcml2KTsK PiA+ID4gPiAtCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2KSB8fCBJU19CUk9BRFdFTEwoZGV2KSkK PiA+ID4gPiAtCQloc3dfcnVudGltZV9yZXN1bWUoZGV2X3ByaXYpOwo+ID4gPiA+IC0JZWxzZQo+ ID4gPiA+ICsJaWYgKElTX0dFTjYoZGV2KSkgewo+ID4gPiA+ICsJCXJldCA9IHNuYl9ydW50aW1l X3Jlc3VtZShkZXZfcHJpdik7Cj4gPiA+ID4gKwl9IGVsc2UgaWYgKElTX0hBU1dFTEwoZGV2KSB8 fCBJU19CUk9BRFdFTEwoZGV2KSkgewo+ID4gPiA+ICsJCXJldCA9IGhzd19ydW50aW1lX3Jlc3Vt ZShkZXZfcHJpdik7Cj4gPiA+ID4gKwl9IGVsc2Ugewo+ID4gPiA+ICAJCVdBUk5fT04oMSk7Cj4g PiA+ID4gKwkJcmV0ID0gLUVOT0RFVjsKPiA+ID4gPiArCX0KPiA+ID4gPiAgCj4gPiA+ID4gKwkv Kgo+ID4gPiA+ICsJICogTm8gcG9pbnQgb2Ygcm9sbGluZyBiYWNrIHRoaW5ncyBpbiBjYXNlIG9m IGFuIGVycm9yLCBhcyB0aGUgYmVzdAo+ID4gPiA+ICsJICogd2UgY2FuIGRvIGlzIHRvIGhvcGUg dGhhdCB0aGluZ3Mgd2lsbCBzdGlsbCB3b3JrIChhbmQgZGlzYWJsZSBSUE0pLgo+ID4gPiA+ICsJ ICovCj4gPiA+ID4gIAlpOTE1X2dlbV9pbml0X3N3aXp6bGluZyhkZXYpOwo+ID4gPiA+ICAJZ2Vu Nl91cGRhdGVfcmluZ19mcmVxKGRldik7Cj4gPiA+ID4gIAlpbnRlbF9yZXNldF9ndF9wb3dlcnNh dmUoZGV2KTsKPiA+ID4gPiAgCj4gPiA+ID4gIAlpbnRlbF9ydW50aW1lX3BtX3Jlc3RvcmVfaW50 ZXJydXB0cyhkZXYpOwo+ID4gPiA+ICAKPiA+ID4gPiAtCURSTV9ERUJVR19LTVMoIkRldmljZSBy ZXN1bWVkXG4iKTsKPiA+ID4gPiAtCXJldHVybiAwOwo+ID4gPiA+ICsJaWYgKHJldCkKPiA+ID4g PiArCQlEUk1fRVJST1IoIlJ1bnRpbWUgcmVzdW1lIGZhaWxlZCwgZGlzYWJsaW5nIGl0ICglZClc biIsIHJldCk7Cj4gPiA+ID4gKwllbHNlCj4gPiA+ID4gKwkJRFJNX0RFQlVHX0tNUygiRGV2aWNl IHJlc3VtZWRcbiIpOwo+ID4gPiA+ICsKPiA+ID4gPiArCXJldHVybiByZXQ7Cj4gPiA+ID4gIH0K PiA+ID4gPiAgCj4gPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBpOTE1X3Bt X29wcyA9IHsKPiA+ID4gPiAtLSAKPiA+ID4gPiAxLjguNAo+ID4gPiA+IAo+ID4gPiA+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+ID4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cj4gPiA+IAo+ID4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK