From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V4 17/24] libxl IDL: generate deep copy functions Date: Tue, 6 May 2014 15:06:24 +0100 Message-ID: <1399385184.3014.154.camel@kazak.uk.xensource.com> References: <1398949101-23320-1-git-send-email-wei.liu2@citrix.com> <1398949101-23320-18-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398949101-23320-18-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote: > Introduces copy_fn for a type. > > For most builtin types we can use direct assignment. For those builtin > types which cannot use direct assignment we use the copy functions in > previous patch. I've only really looked at the generated code. My only real comment is the same as the last one -- can we avoid needing a ctx just for NOGC.