Re: [PATCH] libxl: fix cirrus vga video memory setting with upstream qemu

From: Ian Campbell <Ian.Campbell@citrix.com>
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH] libxl: fix cirrus vga video memory setting with upstream qemu
Date: Thu, 8 May 2014 16:19:57 +0100	[thread overview]
Message-ID: <1399562397.9513.103.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <536B9CC6.2070702@m2r.biz>

On Thu, 2014-05-08 at 17:03 +0200, Fabio Fantoni wrote:
> Il 08/05/2014 13:33, Ian Campbell ha scritto:
> > On Thu, 2014-05-08 at 12:41 +0200, Fabio Fantoni wrote:
> >
> >> About qemu version when vgamem_mb property is added is qemu 1.3, I
> >> already did detailed reply about it in stdvga patch:
> >> http://lists.xen.org/archives/html/xen-devel/2014-05/msg00259.html
> >> Or you mean something other?
> > "in the commit message" is the bit you keep missing.
> 
> I not found 1399030886.32736.63.camel@kazak.uk.xensource.com with google 
> or thunderbird on mail archive, I not understand what post you refer :(

mid.gmane.org is a good way to find these things. e.g.:
http://mid.gmane.org/<1399030886.32736.63.camel@kazak.uk.xensource.com>

Note that the <> which I quoted *are* part of the message id.

The questions there were:
        Is this change correct for all versions of mainline qemu which
        people might be using with Xen?

        Please can you also explain what "wrong" means? Does it crash?
        Does it silently ignore the setting? Does it do something else
        "wrong"? How bad is it?

        > - with this qemu parameters seems correct but for further
        >   confirmation I posted a question about it:
        > http://lists.xen.org/archives/html/xen-devel/2014-04/msg02606.html

        Any reply to this question?

> The question about qemu versions is above,

As I keep saying: These questions should be answered by the *commit
message*.

>  the patch is tested and on 
> domUs show correct video memory size, for example now I'm using windows 
> 7 domUs with stdvga and videoram=64 and on windows in standard video 
> device properties show 64 mb of memory (default is 16 mb).

More information which would be useful in the commit message.

> The only think that I not understand is part of latest Don Slutz reply 
> even if he did "Reviewed-by" on patch.
> 
> Thanks for any reply and sorry for my bad english.