From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C04DC432C2 for ; Wed, 25 Sep 2019 06:06:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DE91217F4 for ; Wed, 25 Sep 2019 06:06:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE91217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD0Rz-0000Vr-Dg for qemu-devel@archiver.kernel.org; Wed, 25 Sep 2019 02:06:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32923) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD0Pq-0007F1-Ej for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:04:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iD0Po-0000vU-23 for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:04:42 -0400 Received: from 17.mo1.mail-out.ovh.net ([87.98.179.142]:40846) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iD0Pn-0000up-Rb for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:04:40 -0400 Received: from player698.ha.ovh.net (unknown [10.108.35.27]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id 2686718C7EC for ; Wed, 25 Sep 2019 08:04:36 +0200 (CEST) Received: from kaod.org (lfbn-1-2229-223.w90-76.abo.wanadoo.fr [90.76.50.223]) (Authenticated sender: clg@kaod.org) by player698.ha.ovh.net (Postfix) with ESMTPSA id 8D187A2DF8F9; Wed, 25 Sep 2019 06:04:31 +0000 (UTC) Subject: Re: [PATCH 4/4] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes To: David Gibson References: <20190924045952.11412-1-david@gibson.dropbear.id.au> <20190924045952.11412-5-david@gibson.dropbear.id.au> <9636ac3a-f0db-7fb8-cb5d-a4a2b83479b5@kaod.org> <20190924114124.GC17405@umbus> <5dca1aae-65d9-c972-e8a8-9d5b8f016c75@kaod.org> <20190925014653.GK17405@umbus> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <13b43747-1082-c803-a998-5b3d49418dc3@kaod.org> Date: Wed, 25 Sep 2019 08:04:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190925014653.GK17405@umbus> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US X-Ovh-Tracer-Id: 248823881762442019 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrfedugddutdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 87.98.179.142 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , gkurz@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 25/09/2019 03:46, David Gibson wrote: > On Tue, Sep 24, 2019 at 04:06:02PM +0200, C=E9dric Le Goater wrote: >> On 24/09/2019 13:41, David Gibson wrote: >>> On Tue, Sep 24, 2019 at 07:31:44AM +0200, C=E9dric Le Goater wrote: >>>> On 24/09/2019 06:59, David Gibson wrote: >>>>> TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever >>>>> instantiated, and the only one we're ever likely to want. The >>>>> existence of different classes is just a hang over from when we >>>>> (misguidedly) had separate subtypes for the KVM and non-KVM version= of >>>>> the device. >>>>> >>>>> So, collapse the two classes together into just TYPE_ICS. >>>> >>>> >>>> Well, I have been maintaining another subclass for the PHB3 MSI=20 >>>> but it has never been merged and it will require some rework. >>> >>> Well, if you did do this again, is there an actual need for it to be = a >>> subclass of ICS_BASE, and not ICS_SIMPLE? AFAICT the merged ICS clas= s >>> should be fine for pnv as well. >> >> the reject resend handlers might be an issue. Anyhow, let's merge this= =20 >> cleanup. PHB3 has been out of tree for too long. >=20 > Hrm, are you sure. I remember thinking the other day "whatever > happened to that PHB3 patchset?". Is it actually broken, It is not broken.=20 PowerNV machines can boot rather complex PCI layouts on P8 (XICS)=20 and P9 (XIVE). See the complex configuration examples here : https://github.com/legoater/qemu/wiki/PowerNV > or has it just been a long time since it was posted, and therefore=20 > been forgotten by me. It hasn't been posted in a long time (+1 year). Here are the latest exchanges we had in November:=20 http://patchwork.ozlabs.org/patch/951227/ Nothing really worrying :=20 - some XICS infrastructure are needed (currently being removed) - check if we need a separate source model for the MSI/LSI=20 - rework the PBCQ modeling to some extent. - misc cleanups. I have been quite busy this last year. I would appreciate if someone=20 could take ownership of the PHB part.=20 C.