All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Edwin Torok <edvin.torok@citrix.com>,
	"Doebel, Bjoern" <doebel@amazon.de>,
	raphning@amazon.co.uk, "Durrant, Paul" <pdurrant@amazon.co.uk>
Subject: Preserving transactions accross Xenstored Live-Update
Date: Tue, 18 May 2021 19:11:40 +0100	[thread overview]
Message-ID: <13bbb51e-f63d-a886-272f-e6a6252fb468@xen.org> (raw)

Hi Juergen,

I have started to look at preserving transaction accross Live-update in 
C Xenstored. So far, I managed to transfer transaction that read/write 
existing nodes.

Now, I am running into trouble to transfer new/deleted node within a 
transaction with the existing migration format.

C Xenstored will keep track of nodes accessed during the transaction but 
not the children (AFAICT for performance reason).

Therefore we have the name of the children but not the content (i.e. 
permission, data...).

I have been exploring a couple of approaches:
    1) Introducing a flag to indicate there is a child but no content.

Pros:
   * Close to the existing stream.
   * Fairly implementation agnostic.

Cons:
   * Memory overhead as we need to transfer the full path (rather than 
the child name)
   * Checking for duplication (if the node was actually accessed) will 
introduce runtime overhead.

     2) Extend XS_STATE_TYPE_NODE (or introduce a new record) to allow 
transferring the children name for transaction

Pros:
   * The implementation is more straight forward

Cons:
    * The stream becomes implementation specific

Neither approach looks very appealing to me. So I would like to request 
some feedback for other proposals or preference between the two options.

Note that I haven't looked into much detail how transactions works on 
OCaml Xenstored.

Cheers,

-- 
Julien Grall


             reply	other threads:[~2021-05-18 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 18:11 Julien Grall [this message]
2021-05-19  9:09 ` Preserving transactions accross Xenstored Live-Update Juergen Gross
2021-05-19 12:32   ` Julien Grall
2021-05-19 12:33     ` Julien Grall
2021-05-19 12:50       ` Juergen Gross
2021-05-19 17:10         ` Julien Grall
2021-05-20  6:41           ` Juergen Gross
2021-05-19 13:42   ` Edwin Torok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13bbb51e-f63d-a886-272f-e6a6252fb468@xen.org \
    --to=julien@xen.org \
    --cc=doebel@amazon.de \
    --cc=edvin.torok@citrix.com \
    --cc=jgross@suse.com \
    --cc=pdurrant@amazon.co.uk \
    --cc=raphning@amazon.co.uk \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.