From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Niestroj Date: Mon, 23 Jan 2017 17:27:09 +0100 Subject: [U-Boot] [PATCH 2/3] ARM: am335x: Add support for chiliSOM In-Reply-To: <20170123155636.GO10853@bill-the-cat> References: <20170123133916.3366-1-m.niestroj@grinn-global.com> <20170123133916.3366-3-m.niestroj@grinn-global.com> <20170123155636.GO10853@bill-the-cat> Message-ID: <13be25e3-2760-9815-9382-fc28e655f919@grinn-global.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Thanks for review! See my comment below. On 23.01.2017 16:56, Tom Rini wrote: > On Mon, Jan 23, 2017 at 02:39:15PM +0100, Marcin Niestroj wrote: > >> chiliSOM is a System On Module (http://http://grinn-global.com/chilisom/). >> It can't exists on its own, but will be used as part of other boards. >> >> Hardware specification: >> * TI AM335x processor >> * 128M, 256M or 512M DDR3 memory >> * up to 256M NAND >> >> Here we treat SOM similar to SOC, so we place it inside arch/arm/mach-* >> directory and make it possible to reuse initialization code (i.e. DDR, >> NAND init) for all boards that use it. This approach is similar as for >> liteSOM module. >> >> Signed-off-by: Marcin Niestroj >> --- >> arch/arm/Kconfig | 2 + >> arch/arm/Makefile | 1 + >> arch/arm/mach-chilisom/Kconfig | 4 + >> arch/arm/mach-chilisom/Makefile | 6 + >> arch/arm/mach-chilisom/chilisom.c | 185 +++++++++++++++++++++++++ >> arch/arm/mach-chilisom/include/mach/chilisom.h | 15 ++ >> 6 files changed, 213 insertions(+) > > These don't belong in a new mach directory, this should end up in > board/grinn/common/ instead, thanks! > This will work for all grinn boards. But the idea is that some other vendor can make a board that will use chilisom as it's base. And in that case sources from board/grinn/common/ directory won't compile. Do you have any idea how to bypass this restriction? -- Marcin Niestroj