From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB282C04AA5 for ; Thu, 25 Aug 2022 12:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239938AbiHYML6 (ORCPT ); Thu, 25 Aug 2022 08:11:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239754AbiHYML5 (ORCPT ); Thu, 25 Aug 2022 08:11:57 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7E96A61C5 for ; Thu, 25 Aug 2022 05:11:55 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id bx38so19208647ljb.10 for ; Thu, 25 Aug 2022 05:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=3jrVz94JeKsDPhrjsPL9t/CAaLqOh9I2BzC2SIj45MQ=; b=NWwcztVUq9UHiIUbxUdpSJiCHvwqmSWTI6qwmDGV/OoFrszYkkSViQlvblRoi8lRVs aHQX8+A3lObNm44aPIxKJdDY8jdvFO6oMakWDJxiRd3/6n3TW1EhEXGEi5aIJ/EjcqOH 7ZjPbl3CnRLbNkKeL6/cA8SkcAkI0W67t/i9BYfLXl7W+gvFDHiQZPSXs5doatEqA1mw DPTRX3beFgpf+LpeIWzDikpxIxIZX07/QpEKYWej5k1VbTUBP/e/UHzXO5PJxmaqsNII OcMwtXQl28EQBsQUGBMQUwU+xcZ+bTXplz3D3tp6SUKTIbOBT2pZlYTFPSZeye+oqsjj 0wEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=3jrVz94JeKsDPhrjsPL9t/CAaLqOh9I2BzC2SIj45MQ=; b=WoVtrSw5CmB0rS3nQ5Ucut9D93x7j0O+lVTsYWF6rH6mQ+ovD5I4FEr3ssOAzHi+MU kowHc9CPiGH5A8wCfzAV3S3oSOMFcFv/Gg1r/1bozbgGlNUNVINrqQnKX8GB5UvGeNsM vx4O9gi+mPPRbcrrNWr0j3CTimlPNDtxSo0d1lj+BjBpbNGpMY1j4hIuNDDnnnwi6Vyr 4QAW/7G6DRKH6JD3MoEpCkvFwbfjaKQQq3VAPY2HBQWx1v+sL4S8x3Az3wqVgQxM4LHo cxxn+8LiqxvpfuW8IZlAU87t3qEYdYE1iUBXtUauhf0LQZi+7IfAnIvEd78SiZvmeRJr KQCQ== X-Gm-Message-State: ACgBeo3Ox0YPDXDAo3pTvlWXu5JevNGjAw8L/prxAHWwb3gEdGT9bPI2 v76pauVa1ywSPClPkRR8C4swBg== X-Google-Smtp-Source: AA6agR4gw2eloZ4Nh2rM/L7T2AOUwLy6E9ahfrjRoJvFJWjTWDiNX4Rd2OKV2NuFBC/Cqv51GDxzDw== X-Received: by 2002:a2e:910f:0:b0:261:ce88:76d2 with SMTP id m15-20020a2e910f000000b00261ce8876d2mr967168ljg.410.1661429513865; Thu, 25 Aug 2022 05:11:53 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id t21-20020ac243b5000000b0048b003c4bf7sm464423lfl.169.2022.08.25.05.11.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 05:11:53 -0700 (PDT) Message-ID: <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> Date: Thu, 25 Aug 2022 15:11:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US To: Linus Walleij Cc: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 25/08/2022 15:08, Linus Walleij wrote: > On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski > wrote: >> On 27/07/2022 03:33, Saravana Kannan wrote: > >>> As soon as a gpio is registered, it should be usable by a consumer. So, >>> do all the initialization before registering the gpios. Without this >>> change, a consumer can request a GPIO IRQ and have the gpio to IRQ >>> mapping fail. >>> >>> Signed-off-by: Saravana Kannan >> >> Looks good. >> >> Linus, >> It's too late for me to pick it up, so make you could grab it directly? >> >> Reviewed-by: Krzysztof Kozlowski >> >> Otherwise it will wait for merge window to finish. > > I sadly missed this during the merge window, as the commit message didn't > make it look like a fix or something urgent. (I don't know if it is?) > Just send me the patch as fix or for -next, I let you decide. I understood, so I already picked it up after merge window. I'll send you this in a pull. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5643AC28D13 for ; Thu, 25 Aug 2022 12:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GxNJaWi/mQ0pYPK+OtW5cVA9AElQQCRZsrPeeD1/KyA=; b=DJSJxG/OJdUNlJ 6vW9eAWvXwFkVID1l13HZMvGenyOGBtkM69hJ63EAxEJinBpmbX/qpbYFn2afXkTjZJBE90pm6zap Jx9Sw3yZ6hqR30xvUpeQ17m04kPRXTwbGTLvvtDEExs0JxdUZibVBO+yBdkB1ihPVBUWC5b7Ik0l4 fisZUmc9hVF9PZ9m8Kk8qfyK1C8cExE7O1Tw9gTfQHJQHySU2AO6yCG+nHdyUHOnMLY5RonSK7UjS 2sM8p3mHpobjy1sVO4QcCYaaKbJttLONUcxmZuYNRbfHA/D/cYuqXX/2g9uQQPcVowAQ++x7cHH+L AAPSm+uFVR4LmiYePb0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBiS-00DVCQ-3s; Thu, 25 Aug 2022 12:12:08 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBiI-00DUwm-J2 for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 12:11:59 +0000 Received: by mail-lj1-x22f.google.com with SMTP id u24so13651645lji.0 for ; Thu, 25 Aug 2022 05:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=3jrVz94JeKsDPhrjsPL9t/CAaLqOh9I2BzC2SIj45MQ=; b=NWwcztVUq9UHiIUbxUdpSJiCHvwqmSWTI6qwmDGV/OoFrszYkkSViQlvblRoi8lRVs aHQX8+A3lObNm44aPIxKJdDY8jdvFO6oMakWDJxiRd3/6n3TW1EhEXGEi5aIJ/EjcqOH 7ZjPbl3CnRLbNkKeL6/cA8SkcAkI0W67t/i9BYfLXl7W+gvFDHiQZPSXs5doatEqA1mw DPTRX3beFgpf+LpeIWzDikpxIxIZX07/QpEKYWej5k1VbTUBP/e/UHzXO5PJxmaqsNII OcMwtXQl28EQBsQUGBMQUwU+xcZ+bTXplz3D3tp6SUKTIbOBT2pZlYTFPSZeye+oqsjj 0wEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=3jrVz94JeKsDPhrjsPL9t/CAaLqOh9I2BzC2SIj45MQ=; b=t7cnvmR3sASbkSEOpaOJVj8M6mlcXzZ2VIMnoEAz4n/B9MN4glzf1zosOpw7zMA4wU mmAYe5Zk7mIiAt29SIrqsLP9Z60fBp+owE9CqPs6P7TSPnSSfmc237tagEwQ7CykkmaU ZMg3uAOHgbLPtuNveb+ClodfKoXhd8gy80f+T3Ejs4EgAgdjcYXu/49SuKx29aEptDHb eqspgyVpDvFTAWCiLSYUViKhBy4E5nnFho9fd7hf5sNEKL34bcI6J24lc4tb3zOKMncW 9+PkZUqGgutNAv7DQVsgBz9fAiNmxv3ER2oI9I8Nrwum02weyJovZ3leC+yEIsyYQMR9 tWGw== X-Gm-Message-State: ACgBeo2dJtLNOHdwKo9b2fbROLG8e6O6aZXQnNWhmm8qBbSqaloe+vqP Cs2maBtof4Rqf+jMwBem5quwKQ== X-Google-Smtp-Source: AA6agR4gw2eloZ4Nh2rM/L7T2AOUwLy6E9ahfrjRoJvFJWjTWDiNX4Rd2OKV2NuFBC/Cqv51GDxzDw== X-Received: by 2002:a2e:910f:0:b0:261:ce88:76d2 with SMTP id m15-20020a2e910f000000b00261ce8876d2mr967168ljg.410.1661429513865; Thu, 25 Aug 2022 05:11:53 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id t21-20020ac243b5000000b0048b003c4bf7sm464423lfl.169.2022.08.25.05.11.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 05:11:53 -0700 (PDT) Message-ID: <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> Date: Thu, 25 Aug 2022 15:11:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US To: Linus Walleij Cc: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_051158_674309_53FA19D7 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/08/2022 15:08, Linus Walleij wrote: > On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski > wrote: >> On 27/07/2022 03:33, Saravana Kannan wrote: > >>> As soon as a gpio is registered, it should be usable by a consumer. So, >>> do all the initialization before registering the gpios. Without this >>> change, a consumer can request a GPIO IRQ and have the gpio to IRQ >>> mapping fail. >>> >>> Signed-off-by: Saravana Kannan >> >> Looks good. >> >> Linus, >> It's too late for me to pick it up, so make you could grab it directly? >> >> Reviewed-by: Krzysztof Kozlowski >> >> Otherwise it will wait for merge window to finish. > > I sadly missed this during the merge window, as the commit message didn't > make it look like a fix or something urgent. (I don't know if it is?) > Just send me the patch as fix or for -next, I let you decide. I understood, so I already picked it up after merge window. I'll send you this in a pull. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel