From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D69CE89CCE for ; Thu, 7 Mar 2019 16:28:37 +0000 (UTC) References: <20190305131611.2367-1-andi.shyti@intel.com> <20190305131611.2367-5-andi.shyti@intel.com> <20190307135426.GD1418@intel.intel> <6fba9cb1-9155-1715-22ea-a44aa12cef6f@linux.intel.com> <20190307154642.GE1418@intel.intel> From: Tvrtko Ursulin Message-ID: <13e2091d-9ff4-3f01-95f1-3523aad1e3b2@linux.intel.com> Date: Thu, 7 Mar 2019 16:28:35 +0000 MIME-Version: 1.0 In-Reply-To: <20190307154642.GE1418@intel.intel> Content-Language: en-US Subject: Re: [igt-dev] [RFC PATCH v10 4/6] lib: ioctl_wrappers: reach engines by index as well List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti Cc: IGT dev , Andi Shyti List-ID: Ck9uIDA3LzAzLzIwMTkgMTU6NDYsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gSGkgVHZydGtvLAo+IAo+ IHllcywgdGhpcyBwYXRjaHNldCBoYXMgZ3Jvd24gYW5kIGNoYW5nZWQgbWFueSB0aW1lcyBvdmVy IHRoZQo+IHJldmlldyBpdGVyYXRpb25zIGFuZCB1bmZvcnR1bmF0ZWx5LCBpdCdzIG5vdCB2ZXJ5 IG9idml1cy4KPiAKPj4+Pj4gV2l0aCB0aGUgbmV3IGVuZ2luZSBxdWVyeSBtZXRob2QgZW5naW5l cyBhcmUgcmVhY2hhYmxlIHRocm91Z2gKPj4+Pj4gYW4gaW5kZXggYW5kIGNvbnRleHQgdGhleSBh cmUgY29tYmluZWQgd2l0aC4KPj4+Pj4KPj4+Pj4gVGhlICdnZW1faGFzX3JpbmcoKScgYmVjb21l cyAnZ2VtX2NvbnRleHRfaGFzX2VuZ2luZSgpJyB0aGF0Cj4+Pj4+IHJlcXVpcmVzIHRoZSBpbmRl eCB0aGF0IHRoZSBlbmdpbmUgaXMgbWFwcGVkIHdpdGhpbiB0aGUgZHJpdmVyLgo+Pj4+Pgo+Pj4+ PiBUaGUgcHJldmlvdXMgJ2dlbV9oYXNfcmluZygpJyBmdW5jdGlvbiBiZWNvbWVzIGEgd3JhcHBl ciB0byB0aGUgbmV3Cj4+Pj4+ICdnZW1fY29udGV4dF9oYXNfZW5naW5lKCknLgo+Pj4+Pgo+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRpQGludGVsLmNvbT4KPj4+Pj4g LS0tCj4+Pj4+ICAgICBsaWIvaW9jdGxfd3JhcHBlcnMuYyB8IDQgKysrLQo+Pj4+PiAgICAgbGli L2lvY3RsX3dyYXBwZXJzLmggfCA0ICsrKy0KPj4+Pj4gICAgIDIgZmlsZXMgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvbGli L2lvY3RsX3dyYXBwZXJzLmMgYi9saWIvaW9jdGxfd3JhcHBlcnMuYwo+Pj4+PiBpbmRleCAzOTky MGY4NzA3ZDIuLmEyNTk3ZTI4MjcwNCAxMDA2NDQKPj4+Pj4gLS0tIGEvbGliL2lvY3RsX3dyYXBw ZXJzLmMKPj4+Pj4gKysrIGIvbGliL2lvY3RsX3dyYXBwZXJzLmMKPj4+Pj4gQEAgLTEyNTIsNyAr MTI1Miw3IEBAIHZvaWQgaWd0X3JlcXVpcmVfZ2VtKGludCBmZCkKPj4+Pj4gICAgIAlpZ3RfcmVx dWlyZV9mKGVyciA9PSAwLCAiVW5yZXNwb25zaXZlIGk5MTUvR0VNIGRldmljZVxuIik7Cj4+Pj4+ ICAgICB9Cj4+Pj4+IC1ib29sIGdlbV9oYXNfcmluZyhpbnQgZmQsIHVuc2lnbmVkIHJpbmcpCj4+ Pj4+ICtib29sIGdlbV9jb250ZXh0X2hhc19lbmdpbmUoaW50IGZkLCB1bnNpZ25lZCByaW5nLCB1 bnNpZ25lZCBjdHgpCj4+Pj4+ICAgICB7Cj4+Pj4+ICAgICAJc3RydWN0IGRybV9pOTE1X2dlbV9l eGVjYnVmZmVyMiBleGVjYnVmOwo+Pj4+PiAgICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY19v YmplY3QyIGV4ZWM7Cj4+Pj4+IEBAIC0xMjY4LDYgKzEyNjgsOCBAQCBib29sIGdlbV9oYXNfcmlu ZyhpbnQgZmQsIHVuc2lnbmVkIHJpbmcpCj4+Pj4+ICAgICAJZXhlY2J1Zi5idWZmZXJzX3B0ciA9 IHRvX3VzZXJfcG9pbnRlcigmZXhlYyk7Cj4+Pj4+ICAgICAJZXhlY2J1Zi5idWZmZXJfY291bnQg PSAxOwo+Pj4+PiAgICAgCWV4ZWNidWYuZmxhZ3MgPSByaW5nOwo+Pj4+PiArCWV4ZWNidWYucnN2 ZDEgPSBjdHg7Cj4+Pj4+ICsKPj4+Pj4gICAgIAlyZXR1cm4gX19nZW1fZXhlY2J1ZihmZCwgJmV4 ZWNidWYpID09IC1FTk9FTlQ7Cj4+Pj4+ICAgICB9Cj4+Pj4+IGRpZmYgLS1naXQgYS9saWIvaW9j dGxfd3JhcHBlcnMuaCBiL2xpYi9pb2N0bF93cmFwcGVycy5oCj4+Pj4+IGluZGV4IGYwYmUyNjA4 MGRhNi4uNDQ2ZTk3M2I3NDQ5IDEwMDY0NAo+Pj4+PiAtLS0gYS9saWIvaW9jdGxfd3JhcHBlcnMu aAo+Pj4+PiArKysgYi9saWIvaW9jdGxfd3JhcHBlcnMuaAo+Pj4+PiBAQCAtMTQyLDExICsxNDIs MTMgQEAgYm9vbCBnZW1faGFzX2V4ZWNfZmVuY2UoaW50IGZkKTsKPj4+Pj4gICAgIC8qIGNoZWNr IGZ1bmN0aW9ucyB3aGljaCBhdXRvLXNraXAgdGVzdHMgYnkgY2FsbGluZyBpZ3Rfc2tpcCgpICov Cj4+Pj4+ICAgICB2b2lkIGdlbV9yZXF1aXJlX2NhY2hpbmcoaW50IGZkKTsKPj4+Pj4gLWJvb2wg Z2VtX2hhc19yaW5nKGludCBmZCwgdW5zaWduZWQgcmluZyk7Cj4+Pj4+ICtib29sIGdlbV9jb250 ZXh0X2hhc19lbmdpbmUoaW50IGZkLCB1bnNpZ25lZCByaW5nLCB1bnNpZ25lZCBjdHgpOwo+Pj4+ PiAgICAgdm9pZCBnZW1fcmVxdWlyZV9yaW5nKGludCBmZCwgdW5zaWduZWQgcmluZyk7Cj4+Pj4+ ICAgICBib29sIGdlbV9oYXNfbW9jc19yZWdpc3RlcnMoaW50IGZkKTsKPj4+Pj4gICAgIHZvaWQg Z2VtX3JlcXVpcmVfbW9jc19yZWdpc3RlcnMoaW50IGZkKTsKPj4+Pj4gKyNkZWZpbmUgZ2VtX2hh c19yaW5nKGZkLCByaW5nKSBnZW1fY29udGV4dF9oYXNfZW5naW5lKGZkLCByaW5nLCAwKQo+Pj4+ PiArCj4+Pj4+ICAgICAvKiBwcmltZSAqLwo+Pj4+PiAgICAgc3RydWN0IGxvY2FsX2RtYV9idWZf c3luYyB7Cj4+Pj4+ICAgICAJdWludDY0X3QgZmxhZ3M7Cj4+Pj4+Cj4+Pj4KPj4+PiBJIGRvbid0 IHVuZGVyc3RhbmQgd2h5IHRoaXMuIEFsbCBjdXJyZW50IGNhbGxlcnMgb2YgZ2VtX2hhc19yaW5n IHBhc3MgaW4gZWIKPj4+PiBmbGFncyBhbmQgbm90IGFuIGluZGV4IHNvIGhvdyBpdCBjYW4gd29y az8KPj4+Cj4+PiBUaGlzIGlzIGJlY2F1c2Ugb2YgcGF0Y2ggMy82IHRoaXMgbWFrZXMgdGhlIGZv cl9lYWNoX2VuZ2luZTIoKQo+Pj4gYWJsZSB0byB3b3JrIHdpdGggbmV3IGFuZCBvbGQgYXBpLgo+ Pgo+PiBIb3cgZG9lcyBpdCBkbyB0aGF0PyBNYXliZSBJIGFtIGV4dHJhIHNsb3cgdG9kYXkuLgo+ IAo+IFdlIGFzc3VtZSB3ZSBoYXZlIHRoZSBvbGQgYXBpIChpLmUuIHdlIHVzZSB0aGUgY3VycmVu dAo+IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltdIGFycmF5KToKPiAKPiAjZGVmaW5lIGZvcl9l YWNoX2VuZ2luZTIoZmQsIGN0eCkgXAo+ICAgICAgICAgICAgICAuLi4KPiAgICAgICAgICAgICAg ICAgICAgIHwtLS0tIHRoZSBmb3JfaWYoKSBpbnZlcnRzIHRoZSBsb2dpYyAtLS0tLS0tLS0tfAo+ ICAgICAgICAgICAgICAgICAgICAgViAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBWCj4gICAgICAgICAgICAgICAgICAgZm9yX2lmIChnZW1faGFzX2VuZ2luZV90 b3BvbG9neSgpIHx8IFwgICAgPC0tLSBmYWxzZQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg Z2VtX2hhc19lbmdpbmUoZmQsIGUyX18tPmNsYXNzLCBlMl9fLT5pbnN0YW5jZSkpIDwtLS0gdHJ1 ZQo+IAo+IGdlbV9oYXNfZW5naW5lKCkgaXMgdGhlIGJpdCB0aGF0IHdpbGwgYmUgY2FsbGVkLCB3 aGljaCB0cmFuc2xhdGVzCj4gY2xhc3MvaW5zdGFuY2UgdG8gZWIgZmxhZyBhbmQgY2FsbHMgZ2Vt X2hhc19yaW5nKGZkLCBmbGFncyksIHdoaWNoIG5vdyBpcwo+IAo+ICNkZWZpbmUgZ2VtX2hhc19y aW5nKGZkLCByaW5nKSBnZW1fY29udGV4dF9oYXNfZW5naW5lKGZkLCByaW5nLCAwKSAoKikKPiAK PiBnZW1fY29udGV4dF9oYXNfZW5naW5lKCkgd291bGQgd29yayBleGFjdGx5IGFzIGJlZm9yZSBh bmQgYXNzaWduCj4gcmluZyB0byBleGVjYnVmLmZsYWdzIGFuZCAnMCcgdG8gZXhlY2J1Zi5yc3Zk MSwgbm90aGluZyBjaGFuZ2VzLAo+IGFsdGhvdWdoIHRoZSBsb2dpYyBpcyBhIGJpdCB0d2lzdGVk ICh3ZSBzdGlsbCBoYXZlIGRpc2N1c3Npb24gb24KPiBuYW1lcyB3aXRoIENocmlzIDopICkuCj4g Cj4gQXQgdGhlIHNhbWUgdGltZSB0aGUgImdlbV9zZXRfY29udGV4dF9nZXRfZW5naW5lcygpIiAo d2hpY2ggbWVhbnMKPiBzZXQgY29udGV4dCBhbmQgZ2V0IGVuZ2luZXMpIGhhcyByZXR1cm5lZAo+ IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltdIGFuZCB3ZSBpdGVyYXRlIHRocm91Z2ggdGhlCj4g cHJlYWxsb2NhdGVkIGVuZ2luZXMuCj4gCj4gSXQgd29ya3MgZXhhY3RseSBsaWtlIGZvcl9lYWNo X2VuZ2luZSguLi4pLCBidXQgdXNpbmcgdGhlIG5ldwo+ICJzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9u X2VuZ2luZTIiIGluc3RlYWQgb2YgdGhlIG9sZCAic3RydWN0Cj4gaW50ZWxfZXhlY3V0aW9uX2Vu Z2luZSIuCj4gCj4gSWYgd2UgaGF2ZSB0aGUgbmV3IHVhcGksIHRoZW4gd2UgZG9uJ3QgY2FyZSwg YmVjYXVzZQo+IGdlbV9oYXNfZW5naW5lX3RvcG9sb2d5IGlzIHRydWUgYW5kIHdlIG1vdmUgZm9y d2FyZDoKPiAKPiAjZGVmaW5lIGZvcl9lYWNoX2VuZ2luZTIoZmQsIGN0eCkgXAo+ICAgICAgICAg ICAgICAuLi4KPiAgICAgICAgICAgICAgICAgICBmb3JfaWYgKGdlbV9oYXNfZW5naW5lX3RvcG9s b2d5KCkgfHwgXCAgICA8LS0tIHRydWUKPiAgICAgICAgICAgICAgICAgICAgICAgICAgIGdlbV9o YXNfZW5naW5lKGZkLCBlMl9fLT5jbGFzcywgZTJfXy0+aW5zdGFuY2UpKSA8LS0tIGRvZXMgbm90 IG1hdHRlcgo+IAo+ICJnZW1fc2V0X2NvbnRleHRfZ2V0X2VuZ2luZXMoKSIgaGFzIHJldHVybmVk IHRoZQo+ICJpbnRlbF9hY3RpdmVfZW5naW5lczJbXSIgYXJyYXkgdGhhdCB3ZSBjcmVhdGVkIGJ5 IHF1ZXJ5aW5nIHRoZQo+IGRyaXZlci4KPiAKPiBPbiB0aGUgb3RoZXIgaGFuZCwgaWYgeW91IHNl ZSB0aGUgc3VidGVzdCAiZXhlYy1jdHgiIChwYXRjaCA2LzYpLAo+IHdlIGNhbGwgZXhhY3RseSB0 aGUgc2FtZSBmdW5jdGlvbiB3aXRob3V0IGdvaW50IHRocm91Z2ggdGhlCj4gZGVmaW5pdGlvbigq KSBhbmQgZ2VtX2NvbnRleHRfaGFzX2VuZ2luZSguLi4pIHdvdWxkIHdvcmsgYnkKPiB1c2luZyB0 aGUgbmV3IGFwaToKPiAKPiAgICAgZ2VtX2NvbnRleHRfaGFzX2VuZ2luZShmZCwgKytpbmRleF9t YXAsIGN0eF9pZCkpOwo+IAo+IGluZGV4X21hcCBpcyBhc3NpZ25lZCB0byBleGVjYnVmLmZsYWdz LCB3aGlsZSBjdHhfaWQgaXMgYXNzaWduZWQKPiB0byBleGVjYnVmLnJzdmQxLgo+IAo+IFRoaXMg ZGVmaW5pdGlvbiByZWR1Y2VzIHF1aXRlIHNvbWUgY29kZSwgYmVjYXVzZSBJIGNhbiB1c2UKPiBn ZW1fY29udGV4dF9oYXNfZW5naW5lKC4uLikgZm9yIGJvdGggaW5kZXhlZCBlbmdpbmVzIGFuZCBu b3QuCj4gCj4gSSBkb24ndCBrbm93IGlmIEkgbWFkZSBteXNlbGYgY2xlYXIsIGJ1dCBpZiB5b3Ug d2FudCB3ZSBjYW4gYWxzbwo+IHRha2UgdGhpcyBvZmZsaW5lLgoKSSB1bmRlcnN0YW5kIHRoZSBs b29wIGl0c2VsZiB3b3JrcywgYnV0IEkgd2FudGVkIHRvIGZpbmQgb3V0IGhvdyBkbyBJIAp3cml0 ZSBhIHRlc3Qgd2hpY2ggdXNlcyBpdCBhbmQgYWN0dWFsbHkgc3VibWl0cyB3b3JrLgoKZm9yX2Vh Y2hfZW5naW5lMihmZCwgY3R4KSB7CgkuLi4KCWViLmZsYWdzID0gPz8/OwoJZWIucnN2ZDEgPSBj dHg7CgoJZ2VtX2V4ZWNidWYoZmQsICZlYik7Cn0KCldoYXQgZG8gSSByZXBsYWNlID8/PyB3aXRo IHNvIHRoZSB0ZXN0IHdvcmtzIG9uIG9sZCBhbmQgbmV3IGtlcm5lbHM/CgpSZWdhcmRzLAoKVHZy dGtvCgo+PiBIb3cgaXMgdGhlIGZvcl9lYWNoX2VuZ2luZTIgd2l0aG91dCBhIGhlbHBlciB0byBn ZXQgZW5naW5lIGZsYWdzLCBvciB0aGUKPj4gaW5kZXggdmFyaWFibGUsIHN1cHBvc2VkIHRvIGJl IHVzZWQgaWYgb25lIHdhbnRzIHRvIHN1Ym1pdCBhIGJhdGNoIHRvIGFsbAo+PiBlbmdpbmVzOgo+ Pgo+PiBmb3JfZWFjaF9lbmdpbmUyKC4uLikKPj4gCWViKGVuZ2luZT0/PykKPj4KPj4gQm90aCBp biBsZWdhY3kgYW5kIGVuZ2luZSBkaXNjb3ZlcnkgbW9kZS4KPj4KPj4gUmVnYXJkcywKPj4KPj4g VHZydGtvCj4+Cj4+PiBIYXZlIEkgbWVzc2VkIHVwIHRoZSBwYXRjaCBvcmRlcj8KPj4+Cj4+PiBB bmRpCj4+Pgo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=