From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602FFC4338F for ; Thu, 29 Jul 2021 09:23:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B5DA6103A for ; Thu, 29 Jul 2021 09:23:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B5DA6103A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 246DE82E0D; Thu, 29 Jul 2021 11:23:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="QnYQuKW4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6ADD882E0D; Thu, 29 Jul 2021 11:22:59 +0200 (CEST) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7C25782E8D for ; Thu, 29 Jul 2021 11:22:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wr1-x436.google.com with SMTP id n12so6068287wrr.2 for ; Thu, 29 Jul 2021 02:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N5mv82+6uvEdd1UI47c0D3iqT0WCpVm/rYfDNHMncnA=; b=QnYQuKW48SuXxlm1/ggJQZPQzJJrc3+sD6sUrB7LfTjjtEuz81U602yOKH+8KGo87A 5VY2+XmvjCP/3SDrc24bDMN6sugNLrwIOu4UJfHECcHMIIn8Wyup7Q+tQptGOWlEwSQT KKQ/nxZW7tsc5LT2Gaz7bHVlxIYXCZp5Z/MZoFmpI+vmh5w8utAl8fL8aaU1RkwlcARh mvgHzw/+FjvSWaJqmspXovD7pZmSAFsXoI2fD6qf5S0c+Bqms86Nn3JD0Izvq0iAZ43W rotmtGaCqesxBKS+tDFsD7CK4ZXZEilgW5OZQ0oCxw3GpHCkY8x9fA8nNwb2TJwL7vrI h0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=N5mv82+6uvEdd1UI47c0D3iqT0WCpVm/rYfDNHMncnA=; b=UalQzROcHdxJr8LlWTtsYyVnF7EP0MSKhF0KW7AEisbY+EwIK3RTJLys4ogdjZk6wn LDlJINkEV1cMZiYkpY1lxVCujGUffaKVcG13tykvXR2MeIoF5TjdVMZuIUlTG2z+Z3hf MgirTNDU42SLcgDhf74M1mlb5a02iKZ69862hMDUF4hHggymlI34nFXs1THxcHnqE3DS YMs9t+SguzTTAzfHEAE7U7NYqa6ZbLqUNATfRi91H0qjevzKorVV5kEvoewo8ZfPJt8b YaGK9jlaGia6YuXvouHknmBMeOqpsZ+G/RpRAKsl0C3EAFEnHVIJ+PhFGjy+0XR7nbYm kYCg== X-Gm-Message-State: AOAM533odV7hXnUYyZagxvtF+PkmBaFdLM+jSK5B3IMQlMv6GIQsnEN2 MaUBCEYTmugaOf0hBqZbxgNRpPYjsVzvuALr X-Google-Smtp-Source: ABdhPJyEpXUSm7nocccWfxuNuWjA6nnZ1Bsu/miltMsI75Es4kiWnbisQZUoFCQ41v2Dx9C6BDPT6g== X-Received: by 2002:adf:f64b:: with SMTP id x11mr3703309wrp.155.1627550572685; Thu, 29 Jul 2021 02:22:52 -0700 (PDT) Received: from [10.1.3.29] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id l3sm6561086wmq.2.2021.07.29.02.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 02:22:52 -0700 (PDT) Subject: Re: [PATCH 5/6] configs: meson64_android: use logo part label instead of index To: Mattijs Korpershoek Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de References: <20210729072113.208099-1-mkorpershoek@baylibre.com> <20210729072113.208099-6-mkorpershoek@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <13e2b768-c713-65de-3805-930a7893ca59@baylibre.com> Date: Thu, 29 Jul 2021 11:22:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729072113.208099-6-mkorpershoek@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 29/07/2021 09:21, Mattijs Korpershoek wrote: > To display the bootup logo, we read the gpt and assume that the > partition with index "2" will be the "logo" partition. > > This might not always be the case, and it's very error-prone. > > Load the logo partition by label instead of by index. > > Signed-off-by: Guillaume La Roque > Signed-off-by: Mattijs Korpershoek > --- > include/configs/meson64_android.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h > index e22f05c889..56545a72f8 100644 > --- a/include/configs/meson64_android.h > +++ b/include/configs/meson64_android.h > @@ -13,6 +13,10 @@ > #define BOOT_PARTITION "boot" > #endif > > +#ifndef LOGO_PARTITION > +#define LOGO_PARTITION "logo" > +#endif > + > #define BOOTENV_DEV_FASTBOOT(devtypeu, devtypel, instance) \ > "bootcmd_fastboot=" \ > "sm reboot_reason reason;" \ > @@ -104,8 +108,8 @@ > "if test \"${boot_source}\" != \"usb\" && " \ > "gpt verify mmc ${mmcdev} ${partitions}; then; " \ > "mmc dev ${mmcdev};" \ > - "part start mmc ${mmcdev} ${logopart} boot_start;" \ > - "part size mmc ${mmcdev} ${logopart} boot_size;" \ > + "part start mmc ${mmcdev} " LOGO_PARTITION " boot_start;" \ > + "part size mmc ${mmcdev} " LOGO_PARTITION " boot_size;" \ > "if mmc read ${loadaddr} ${boot_start} ${boot_size}; then " \ > "bmp display ${loadaddr} m m;" \ > "fi;" \ > @@ -114,7 +118,6 @@ > #define CONFIG_EXTRA_ENV_SETTINGS \ > "partitions=" PARTS_DEFAULT "\0" \ > "mmcdev=2\0" \ > - "logopart=2\0" \ > "gpio_recovery=88\0" \ > "check_button=gpio input ${gpio_recovery};test $? -eq 0;\0" \ > "load_logo=" PREBOOT_LOAD_LOGO "\0" \ > Acked-by: Neil Armstrong