From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCHSET v2] block: IO polling improvements To: 1478202307-1947-1-git-send-email-axboe@fb.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: <20161107152824.GA20916@cgy1-donard.priv.deltatee.com> From: Jens Axboe Message-ID: <13f97b32-bdd6-6013-2b99-6690af125a4c@fb.com> Date: Mon, 7 Nov 2016 08:29:57 -0700 MIME-Version: 1.0 In-Reply-To: <20161107152824.GA20916@cgy1-donard.priv.deltatee.com> Content-Type: text/plain; charset=windows-1252; format=flowed List-ID: On 11/07/2016 08:28 AM, Stephen Bates wrote: >> Fixed a few bugs in this, and addressed some review comments. Patches >> are against my 4.10 block branch, for-4.10/block. > > Jens > > Thanks for proposing this. Looks very cool. I will try and get you a > review and some testing this week... Sounds good. Be sure to use the latest git branch (for-4.10/dio), there's been some fixes since the posting. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329AbcKGPa6 (ORCPT ); Mon, 7 Nov 2016 10:30:58 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:37466 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbcKGPaM (ORCPT ); Mon, 7 Nov 2016 10:30:12 -0500 Subject: Re: [PATCHSET v2] block: IO polling improvements To: <1478202307-1947-1-git-send-email-axboe@fb.com>, , References: <20161107152824.GA20916@cgy1-donard.priv.deltatee.com> From: Jens Axboe Message-ID: <13f97b32-bdd6-6013-2b99-6690af125a4c@fb.com> Date: Mon, 7 Nov 2016 08:29:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161107152824.GA20916@cgy1-donard.priv.deltatee.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM2PR10CA0036.namprd10.prod.outlook.com (10.160.213.46) To MWHPR15MB1200.namprd15.prod.outlook.com (10.175.2.142) X-MS-Office365-Filtering-Correlation-Id: a294b8d0-abf5-418d-9fc9-08d40722f549 X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;2:AUhcZL//hIUizlbdHaZIo0yEj86WbGqaSjus12fETRva3XchHILI2bnnE0ynNLwaXxHeEcvuQo2YxAzoBT72tJyJRL3qM3xp0NrVglZZJRcwrwEbzyppnkCgInqyIClCrRG/XxMdS5EGIRl42aOHBmv1fxjtvFhyTK0q6XaruM3dmnnzoG3aNJNAiUAOHXcQqhHmZ6UK7DU2Sj8CQoxGjw==;3:J17viqnWeA2oLoOFWtSq65n0aCJ/Iq5bFEWI6a9MhFGNglWJzddszRNlgKTWEK+ipGmRRi6CbnzJdqnOSEqHlp221Vj+ywI+hRtOGDjAkpfvZE1orSu9ksjqBjTe9RCA/MzqjM1LAaXP334NQDrgnA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1200; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;25:RmJZ0vYPKtjmxa+WWekAkAX4pMImjjyVYr9056V+RGR/Jr20bbKche8cxvoyszN58xLGi1sW38R3v7eMrYCDZbZGV0EY/fF8sTqow7KRAZwB0IVAQxjGuFf272A5yuOy1X9SlSy7XVLL5AIfwBvFoYHI+GUY1PYeA5xutjh8Tfbs/lwRtjCFuQuqiSkOVG8KjAnWf8pPyJIvQL6PafdUVuGtueWhpiUg5cr3LI9mf7FPUUOeGVnsWovfgXfQWbv1zTXp3vM9iXIXNGcBS8BoMgIuwK4esgOACKSBciTAthMFQvcY2/ZztTYDrepRWi3mZ/gd92cw2zKYig9ug8zCSdc7BcimINlx/5EqzPDBhK9VMadCO1n4CAOLWVw0ZU4Lp0gX8pkjct/LGDpl1IPPCDf4NcUBHlOUYFPVRDF2K4Ly9vWRjwnqZUJifQw2/1PgeEMIQJbUulbGi/ntsaTqlZPp2ewaaeWvlXbTyj3f29ewEs6yFnGm7SCOaGiqoxwniKWBmcEkPU5ViAE4d6Pjs5eXcUORks2izLmnIfN10ALPTnEmjnnbwEsL7AvS1eKjELbN6S70DqGgeiI6bTATfxyZpkqFSf9DnA3s43oxNdHSqmiK4bIPAo52HowR2LHzFCitdEnCf0NlfHjvLXSKzOQFemMjTHWXX9CZPqdGstHsh+bLf7PeP24GkjIwqAfI0sdN1Nbn89SzNpTnM1WoGTPaF59v4ZUoH1AAMKK9W6A= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;31:8qOXRyC9o5V/Ch2DrUj8//zQUd2OMeCbHp2RinPaks5JekPh/6WqGkLNAyt6nXA8dyNYRLxZUfxpnH0pQTXkFbZ3DkHMXZ5CGe9rgAR62g1NUiHK2LvqkfsUyId318uRML/oDD9BtTA/tcrf8EqhjfxTsfrk4vKOR8P8BXGBurf72XgsxQ5QuIiQXkOqIn3zlAARGHYVm54x5Ez77g5euOmHOixUh6v+nmiR4gylaW48EU7ViBdOvRPGVY8YB2mk+VX2pRJpreGxXEc0iWT0cZzwHGBqmjXrtz5KzkrPL60=;20:zGE5nOaFqG9+tFno4+28BmzDk9mu+tTyPkKtLr0axDgVrRYusaNc8P2U9xofLL28f2RoOkZ0hb4snwe3l/SkEFuJJkXCoObRE70Sa0J/4GgmRiI2KnPlDlFswjFg3zKdN32QpH2kT/Dw6hVtA1Gx3GtpwwHeoA1kL4vU7Hx0Eb0=;4:aJcv5PRTMo7G7wvrldV9UlVgZf76Ggbg6uiBute0EOCxC7vhhsg5Te9HisLC9KbvKNW+Iri7vw4cXgjotP22Cu7eqf37fPdE/nkvJRtF64qCIAl3Ic2NaL/OdG9TvBAYIUYciKeVlGYyn8MYjRBG2PFyaoNtZi/i0IMHjG4BvZwSHFevIJhDUXL316ZJCK9E0bK0bk4yA1vWtQPyIeoi9baeoAhxUHQB4TEtI90jO+TeyIjgKWgXpdZiF8yYpfpyMMYlDBFFT5g66ttYBAgdFGe0U9AClnhuTr9XiEryBnzcF0NpEEFDD1RxJnEVeA2WSe19AWszi/P3CBlFr37M0ubmTHUahL6XFSmpNXr1OfKs1PmNnUh4NIyhIQ/KeynGzRGxec7uae79/yW5CdJCPw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:MWHPR15MB1200;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1200; X-Forefront-PRVS: 0119DC3B5E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(24454002)(377454003)(189002)(31696002)(2950100002)(86362001)(77096005)(2201001)(107886002)(2906002)(230700001)(54356999)(76176999)(50986999)(117156001)(6666003)(23746002)(6116002)(305945005)(3846002)(586003)(5660300001)(65826007)(64126003)(47776003)(101416001)(189998001)(66066001)(65956001)(450100001)(81166006)(81156014)(8676002)(42186005)(31686004)(7846002)(105586002)(7736002)(106356001)(50466002)(92566002)(65806001)(5001770100001)(33646002)(97736004)(4001350100001)(83506001)(36756003)(68736007);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1200;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1200;23:FADCcrm6OZ7qdswQ+QUsgtmU4GN+p8YmvSdc1?= =?Windows-1252?Q?+1T9VxslhT/Kkkg0dqcaA/OxOwjtup9UnaQkIsMYCt2MjGLHlmPl62Ri?= =?Windows-1252?Q?qhAWwbDoaoEWFSft2vHJkJGWh5q8HZTRdxKL+jqIZkRkPhgPqMGEHoVO?= =?Windows-1252?Q?CmFp9GgewLk5+3aEymt+ZQmyzZfafPGGJi3W45GWXl45axkqi0UCYy1m?= =?Windows-1252?Q?HYuVtSOb93bCk07vL6hdPxgpcQ4GW0bfai8Sx3xKuyvEWLsSka29CAbq?= =?Windows-1252?Q?ph1jLzQbkU1TVq14BfpcQX7K5pqslZ0tzi5eyrdUwtKQkgFr7fD7pDs8?= =?Windows-1252?Q?H83Jnb6LuR/VDkyeLMSGFkrgoRLtomZAK+qwUD7ZLaQ6bcDv4l5dk6np?= =?Windows-1252?Q?SD3Ob4wA7O1JbGujpKEpdKF7tUKHfNVvf1jfqUQgMm7F0mtCbqlIu6Ih?= =?Windows-1252?Q?qvx5i4fhM46x2PcsHlnh8kT+nkI8l7VEFyLkttNR6YwCR7ZUXTn921Ax?= =?Windows-1252?Q?orDR0NCInD16gmdSDrhpFCPPXtAzkdRwcTKc49tqib3HVHc3UI1H+tY0?= =?Windows-1252?Q?xSEiZvzwnPIv6dCHdMvNJldYyOviul4G1MaUOHqabBu4AQ0OLRbpjZa9?= =?Windows-1252?Q?9F9OKzMZ6SzqDSF9RSNEz5o73qnBv6FH61BVD1PCYmjFTdhwaAdU3QKN?= =?Windows-1252?Q?skTs/5ifT51k0kuHjZ9guCBEfT7EsC0pxzeWchy+uHQf76S1EZsn6q/S?= =?Windows-1252?Q?1TzhNkgFOIjquDTiCELFTJcnRMP7c5IyjanWDd9qlrzN85LMKQKA75Oi?= =?Windows-1252?Q?qeutxa2y/bCN9RABos4ZYVYiEi168eo2dmxjC9Wm7372OGQqBvcIBg0k?= =?Windows-1252?Q?JFllwm+ocrQg5Z7xBoQJgzNInC88abGmB4HNhX8cphgQINaYVZkJXE3r?= =?Windows-1252?Q?9Y2hbTcKs+W/Mm9Bqq6xMai9CnrKGDAvKxO1xGqt5cnwStSdGFUp2Ex2?= =?Windows-1252?Q?YcY5pAZjOSuWew5Y9ZhH7uwK99D2BpuGqLCNCthdulOYgq9Xr0FKfcN+?= =?Windows-1252?Q?VnqV+d5UtED0G2klz4lpudxMiIlhStD/oXZK9cmcl3Gpnhl2n/6lmRoT?= =?Windows-1252?Q?u3U2z7LSSG16Kt/Yohd13pv04U2sCi3hfsT4MiXxexPoQf3j55UpLyuC?= =?Windows-1252?Q?WG3a3TIPI97jfnxv/Hnil8AHCT6/kQk+tKIcSUwNFDKQKAa5a1ffPWuE?= =?Windows-1252?Q?uFQ/UKX2VVzCAzDsH/u3YexWBRb+imk7c0+0hGvfCudk2wDnJ5lj5e5C?= =?Windows-1252?Q?2A+m+eZJ3Wr2s3NGKnycc9cqjKMESfT9zIAt7WX1zaTMaSVr24DqWL6T?= =?Windows-1252?Q?78mN1dPa0ZOEQ2hdl9EsQvZTokhxfg/qVDEMk/QUPUd8RfRkqSUHZLQ/?= =?Windows-1252?Q?CuwuNbmxI3xusU1atku?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;6:lA6tEIxxsXqp4IsoNGt5c/RgESkLoE8RK+DM0jmlRmwNm2jNN/U9/3sh+j5DSwVojzNTeZ98pBVetNS5p4lOAWqvRv7EiZw4tHU4koXstyJc6NFfw8/p8tsAJxJTXJltY1sYd2yfnzQOlvIXdcDVkrT6MwP8wRnshPim2B6CyCXmBIXnTS6SSS6o37M1HQgiWC70UYhbdLp7aiFGFFhmD+5wSOKhplxQVn94bSIS90FJbyjGA4957dYI0AQC6vNQ92rlcD9I83+Ai46INGNy9J8RdvQWfCu/42F2b3R8gSrSO3idaSW0INSBFz5als0p;5:CIQflQHuWd62oMJmQuU9pCBo2/zxRwALmzLVACSUBE5TAm1iNkddwS10LkscuRtmYefyoGNsLgjE9QYl1HAuSI2XqxZk1ShogyU2bUex8MdkcGNJ7KhWUBspKUu+ro2UE7uc3vF7XI4pmhAbZx2vAA==;24:0K53dMmScxjVTb++EnUkYivpA9iFXNHjtHkjZRBd6qPLgFEV9udMVF02AZWt31iJv4XW434K0yb0z1nfmfTpjUOaTWXAMYro5Y+r5R6tDQo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;7:KsaSEN9OBmP3daBolUk8GGjHcC1UybUPDZ8i23rOoexJxrb6/ZXeKFNaoWmfJPXCZn2m4GDjHnWLSZgnYs3L9U5k1iAtNmQo/d3r6Rb+jS5QAi4Cd4M9vM0sKqr5YYZwjD21yaOs38ZRsfwDSsfdvUuKm9v9yQ7/AEYS8YxUrB3/t+kZ4s0yfzQXoZ+LDFXKkUFXMpLG5UgWxcH8w9BY5fWGLNYunOKMzyDgq44ztsQhW0suizjKozewxhI4W14L0QATgTdrmUofsBwT1PBX0KdkEAoY/1PeKlDTcluQb1djJy/3aZU8Dpt/veSSFe5qFDsZiqLXPaSgjro0s0M4p2fSYeK87tQBNspB4EUQLHQ=;20:t1Nh/67olRph7haDW7ztWYjbDMnMjxKDbx5a0zj/OOn0UCOpuuVR+bWzfXW4RR9Asr/GcP6FROkpfMaIN6Uuvuu4ny7kp7340Y2B5APx2UkpL9ojvJWAhZDbanomQHhAbqRSOwzMAfpXINVtnMrgdBhCdbeXuvcmdxaIrtVNEbo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 15:30:07.3542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1200 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-07_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2016 08:28 AM, Stephen Bates wrote: >> Fixed a few bugs in this, and addressed some review comments. Patches >> are against my 4.10 block branch, for-4.10/block. > > Jens > > Thanks for proposing this. Looks very cool. I will try and get you a > review and some testing this week... Sounds good. Be sure to use the latest git branch (for-4.10/dio), there's been some fixes since the posting. -- Jens Axboe