From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755992AbcG0LVz (ORCPT ); Wed, 27 Jul 2016 07:21:55 -0400 Received: from mail.eperm.de ([89.247.134.16]:33822 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755187AbcG0LVx (ORCPT ); Wed, 27 Jul 2016 07:21:53 -0400 From: Stephan Mueller To: David Howells Cc: x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace Date: Wed, 27 Jul 2016 13:21:48 +0200 Message-ID: <14001554.0xCMXCgYeT@tauon.atsec.com> User-Agent: KMail/5.2.3 (Linux/4.6.3-300.fc24.x86_64; KDE/5.23.0; x86_64; ; ) In-Reply-To: <146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk> References: <146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells: Hi David, > x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than > calling sys_keyctl. The latter will work in a lot of cases, thereby hiding > the issue. > > Reported-by: Stephan Mueller > Signed-off-by: David Howells Tested-by: Stephan Mueller > cc: stable@vger.kernel.org > --- > > arch/x86/entry/syscalls/syscall_32.tbl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl > b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea > 100644 > --- a/arch/x86/entry/syscalls/syscall_32.tbl > +++ b/arch/x86/entry/syscalls/syscall_32.tbl > @@ -294,7 +294,7 @@ > # 285 sys_setaltroot > 286 i386 add_key sys_add_key > 287 i386 request_key sys_request_key > -288 i386 keyctl sys_keyctl > +288 i386 keyctl sys_keyctl compat_sys_keyctl > 289 i386 ioprio_set sys_ioprio_set > 290 i386 ioprio_get sys_ioprio_get > 291 i386 inotify_init sys_inotify_init Ciao Stephan