From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754522AbaESNyi (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 May 2014 09:54:38 -0400
Received: from mail-pb0-f51.google.com ([209.85.160.51]:56719 "EHLO
	mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751331AbaESNyh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 May 2014 09:54:37 -0400
Subject: Re: [PATCH 06/20] perf tools: Consolidate output field handling to
 hpp format routines
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>
In-Reply-To: <20140519131257.GC20810@krava.brq.redhat.com>
References: <1400480762-22852-1-git-send-email-namhyung@kernel.org>
	 <1400480762-22852-7-git-send-email-namhyung@kernel.org>
	 <20140519131257.GC20810@krava.brq.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 19 May 2014 22:54:31 +0900
Message-ID: <1400507671.1742.4.camel@leonhard>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2014-05-19 (월), 15:12 +0200, Jiri Olsa:
> On Mon, May 19, 2014 at 03:25:48PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > @@ -1104,27 +1104,35 @@ static int hist_browser__fprintf_entry(struct hist_browser *browser,
> >  				       struct hist_entry *he, FILE *fp)
> >  {
> >  	char s[8192];
> > -	double percent;
> >  	int printed = 0;
> >  	char folded_sign = ' ';
> > +	struct perf_hpp hpp = {
> > +		.buf = s,
> > +		.size = sizeof(s),
> > +	};
> > +	struct perf_hpp_fmt *fmt;
> > +	bool first = true;
> > +	int ret;
> >  
> >  	if (symbol_conf.use_callchain)
> >  		folded_sign = hist_entry__folded(he);
> >  
> > -	hist_entry__sort_snprintf(he, s, sizeof(s), browser->hists);
> > -	percent = (he->stat.period * 100.0) / browser->hists->stats.total_period;
> > -
> >  	if (symbol_conf.use_callchain)
> >  		printed += fprintf(fp, "%c ", folded_sign);
> >  
> > -	printed += fprintf(fp, " %5.2f%%", percent);
> > -
> > -	if (symbol_conf.show_nr_samples)
> > -		printed += fprintf(fp, " %11u", he->stat.nr_events);
> > +	perf_hpp__for_each_format(fmt) {
> > +		if (perf_hpp__should_skip(fmt))
> > +			continue;
> 
> this one is defined in later patch, so it breaks build in this one

Argh, right.  This one came from a later fixup with interactive rebase
and missed test..  I'll fix and resend, sorry about that.

Thanks,
Namhyung