From: "Brad Mouring" <bmouring@ni.com>
To: linux-rt-users@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>, Brad Mouring <brad.mouring@ni.com>
Subject: [PATCH 1/1] rtmutex: Handle when top lock owner changes
Date: Fri, 23 May 2014 09:30:10 -0500 [thread overview]
Message-ID: <1400855410-14773-2-git-send-email-brad.mouring@ni.com> (raw)
In-Reply-To: <1400855410-14773-1-git-send-email-brad.mouring@ni.com>
If, during walking the priority chain on a task blocking on a rtmutex,
and the task is examining the waiter blocked on the lock owned by a task
that is not blocking (the end of the chain), the current task is ejected
from the processor and the owner of the end lock is scheduled in,
releasing that lock, before the original task is scheduled back in, the
task misses the fact that the previous owner of the current lock no
longer holds it.
Signed-off-by: Brad Mouring <brad.mouring@ni.com>
Acked-by: Scot Salmon <scot.salmon@ni.com>
Acked-by: Ben Shelton <ben.shelton@ni.com>
Tested-by: Jeff Westfahl <jeff.westfahl@ni.com>
---
kernel/locking/rtmutex.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index fbf152b..029a9ab 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -384,6 +384,25 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task,
/* Deadlock detection */
if (lock == orig_lock || rt_mutex_owner(lock) == top_task) {
+ /*
+ * If the prio chain has changed out from under us, set the task
+ * to the current owner of the lock in the current waiter and
+ * continue walking the prio chain
+ */
+ if (rt_mutex_owner(lock) && rt_mutex_owner(lock) != task) {
+ /* Release the old owner */
+ raw_spin_unlock_irqrestore(&task->pi_lock, flags);
+ put_task_struct(task);
+
+ /* Move to the new owner */
+ task = rt_mutex_owner(lock);
+ get_task_struct(task);
+
+ /* Let's try this again */
+ raw_spin_unlock(&lock->wait_lock);
+ goto retry;
+ }
+
debug_rt_mutex_deadlock(deadlock_detect, orig_waiter, lock);
raw_spin_unlock(&lock->wait_lock);
ret = deadlock_detect ? -EDEADLK : 0;
--
1.8.3-rc3
next prev parent reply other threads:[~2014-05-23 14:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 14:30 [PATCH 0/1] Faux deadlock detection fixup Brad Mouring
2014-05-23 14:30 ` Brad Mouring [this message]
2014-06-04 1:06 ` [PATCH 1/1] rtmutex: Handle when top lock owner changes Steven Rostedt
2014-06-04 13:05 ` Brad Mouring
2014-06-04 14:16 ` Steven Rostedt
2014-06-04 14:38 ` Brad Mouring
2014-06-04 14:58 ` Steven Rostedt
2014-06-04 15:11 ` Brad Mouring
2014-06-04 15:32 ` Thomas Gleixner
2014-06-04 15:44 ` Steven Rostedt
2014-06-04 18:02 ` Thomas Gleixner
2014-06-04 18:12 ` Steven Rostedt
2014-06-04 20:49 ` Thomas Gleixner
2014-06-04 19:25 ` Brad Mouring
2014-06-04 19:53 ` Thomas Gleixner
2014-06-04 20:07 ` Brad Mouring
2014-06-04 20:41 ` Thomas Gleixner
2014-06-04 22:22 ` [PATCH] " Brad Mouring
2014-06-04 23:03 ` Thomas Gleixner
2014-06-06 3:19 ` [PATCH 1/1] " Steven Rostedt
2014-06-06 5:40 ` Thomas Gleixner
2014-06-06 5:44 ` Thomas Gleixner
2014-06-06 8:53 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400855410-14773-2-git-send-email-brad.mouring@ni.com \
--to=bmouring@ni.com \
--cc=brad.mouring@ni.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.