From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 4/4] drm/i915: make sure PC8 is enabled on suspend and disabled on resume Date: Mon, 02 Jun 2014 14:37:35 +0300 Message-ID: <1401709055.1590.11.camel@intelbox> References: <1401397897-4655-1-git-send-email-jbarnes@virtuousgeek.org> <1401397897-4655-4-git-send-email-jbarnes@virtuousgeek.org> <20140602084522.GM19050@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0220967612==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id EA6C46E481 for ; Mon, 2 Jun 2014 04:37:38 -0700 (PDT) In-Reply-To: <20140602084522.GM19050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, kristen@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org --===============0220967612== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-m0bQQwlPn3U4hH63CFTv" --=-m0bQQwlPn3U4hH63CFTv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2014-06-02 at 10:45 +0200, Daniel Vetter wrote: > On Thu, May 29, 2014 at 02:11:37PM -0700, Jesse Barnes wrote: > > From: Kristen Carlson Accardi > >=20 > > This matches the runtime suspend paths and allows the system to enter > > the lowest power mode at freeze time. > >=20 > > Signed-off-by: Kristen Carlson Accardi > > Signed-off-by: Jesse Barnes >=20 > pc8 is fully subsumed into runtime pm by now. Do we _really_ still need > this? Yes, since the system suspend/resume handlers are called with an RPM ref held and thus PC8 disabled. --Imre > -Daniel >=20 > > --- > > drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i91= 5_drv.c > > index b6211d7..24dc856 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -558,6 +558,9 @@ static int i915_drm_freeze(struct drm_device *dev) > > =20 > > intel_display_set_init_power(dev_priv, false); > > =20 > > + if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > > + hsw_enable_pc8(dev_priv); > > + > > return 0; > > } > > =20 > > @@ -618,6 +621,9 @@ static int __i915_drm_thaw(struct drm_device *dev, = bool restore_gtt_mappings) > > { > > struct drm_i915_private *dev_priv =3D dev->dev_private; > > =20 > > + if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > > + hsw_disable_pc8(dev_priv); > > + > > if (drm_core_check_feature(dev, DRIVER_MODESET) && > > restore_gtt_mappings) { > > mutex_lock(&dev->struct_mutex); > > --=20 > > 1.9.1 > >=20 > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >=20 --=-m0bQQwlPn3U4hH63CFTv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTjGH/AAoJEORIIAnNuWDFqBUH/3KkGfWimjVFPORfEM4ycw4M jW9bDr1jPffxdTdXhElCHgBvAaVdjf/52oSaQ0WVfTEV0WsjI6jlEatoi4f5P5+9 Sr1U0PgPx+VqBdt/wie1sDwR6fNTRQMf/rbis4U0JjstYK3hFtUcjJFCp8qEj5Gp XNOPmldBfvku3Z4KLuGQ1hRJAAdQo5x54y3ky0IoMey1p5T4kT8vOQTr7Fu51K0n 0HpXAFlEL0Nf/+7mrTy6xiH7LPXwcmfPAjrDk6I5Ng/S3T4NySzMsLYBonJVG6au /gerTHUuASxfrj2GJ9abyOPaCY5JksE9AVukEXB1gUZUMnzrwnJBr4S5I+LyNK0= =Qlah -----END PGP SIGNATURE----- --=-m0bQQwlPn3U4hH63CFTv-- --===============0220967612== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0220967612==--