From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 4/4] drm/i915: make sure PC8 is enabled on suspend and disabled on resume Date: Mon, 02 Jun 2014 18:57:18 +0300 Message-ID: <1401724638.1590.26.camel@intelbox> References: <1401397897-4655-1-git-send-email-jbarnes@virtuousgeek.org> <1401397897-4655-4-git-send-email-jbarnes@virtuousgeek.org> <20140602084522.GM19050@phenom.ffwll.local> <1401709055.1590.11.camel@intelbox> <20140602153217.GX19050@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1241953303==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 520A96E5E8 for ; Mon, 2 Jun 2014 08:57:27 -0700 (PDT) In-Reply-To: <20140602153217.GX19050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, kristen@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org --===============1241953303== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Y+lVmcInIT9r6cbnU5o8" --=-Y+lVmcInIT9r6cbnU5o8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2014-06-02 at 17:32 +0200, Daniel Vetter wrote: > On Mon, Jun 02, 2014 at 02:37:35PM +0300, Imre Deak wrote: > > On Mon, 2014-06-02 at 10:45 +0200, Daniel Vetter wrote: > > > On Thu, May 29, 2014 at 02:11:37PM -0700, Jesse Barnes wrote: > > > > From: Kristen Carlson Accardi > > > >=20 > > > > This matches the runtime suspend paths and allows the system to ent= er > > > > the lowest power mode at freeze time. > > > >=20 > > > > Signed-off-by: Kristen Carlson Accardi > > > > Signed-off-by: Jesse Barnes > > >=20 > > > pc8 is fully subsumed into runtime pm by now. Do we _really_ still ne= ed > > > this? > >=20 > > Yes, since the system suspend/resume handlers are called with an RPM re= f > > held and thus PC8 disabled. >=20 > But doesn't patch 1 try to fix that? That only disables the display side, but we won't disable PC8 until the RPM suspend handler is called. And that won't happen because the last RPM ref is held by the DPM framework for the duration of system suspend/resume handlers. > Imo we should have this here but instead go through highl-level the runti= me > pm functions to shut off the chip on all platforms. After the planned refactoring we could have a low-level function that we can call both from here and the runtime PM path, but until that happens we need to do this here directly. --Imre --=-Y+lVmcInIT9r6cbnU5o8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTjJ7eAAoJEORIIAnNuWDFI1UIAKSZvRB/h6s/xTl4rZeYbvLe Whp1gVVu9uku4suA7y2WZI5JjIsZOm1ajB//IXPspt9mNTDUohvpi57i7pW0Tw2/ L2b5ONoXPhoXLoxQ+6QUt3bsxEgPWXGdTJiVHmbT8mC3SmixXwEcx6LXe9RaSpKn xMb/ItN1DAUNskfg8Qk+DDrCFmnJq3SlKCaTVhlUARQreas54S608cANKWnHZPje 5J1Ffg/FXa8jSvHho63JVZIo7iHwlC72R4zZlhdQpAf/Ja8md3Ibfj8gNn5utlRw ZD8jKSYVN9fLGivxal7zWcHjnlJ45RNfUUqyli7vqNtc9OeV58oKZFRQfMHk2HE= =645X -----END PGP SIGNATURE----- --=-Y+lVmcInIT9r6cbnU5o8-- --===============1241953303== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1241953303==--